feat: remove background, add hover, delete background parameter to icon #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
force-pushed
the
remove-background
branch
from
23199d0
to
4cea43f
Compare
|
could you please only enhance the list without the details ? |
|
@benoitf Were retrieving the class from the same file. Changing one unfortunately affects the other until UI/UX finalized what it looks like on the detailed screen. We could add an if statement as well as another file similar to how we did Could we do this for now? |
|
I think we can provide flags to keep existing layout for one case and not the other one. I would not introduce a rectangle or anything, just keeping the previous rendering. |
|
Updated! See below screenshots. I've also updated it across all other parts too (volumes and images). |
cdrage
force-pushed
the
remove-background
branch
from
4683ec3
to
ef9189a
Compare
### What does this PR do?
* Removes the background on list and details for a "hover" circle
* Delete the background parameter for icons
Note: Reasoning for deleting background parameter: No longer needed as
no longer adding a background. Tailwind also does not show the hover
correctly as a parameter (ex. class="{backgroundColor} m-2") with hover.
### Screenshot/screencast of this PR
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
remove-background
branch
from
ef9189a
to
80e6862
Compare
benoitf
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove background, add hover, delete background parameter to icon
What does this PR do?
Note: Reasoning for deleting background parameter: No longer needed as
no longer adding a background. Tailwind also does not show the hover
correctly as a parameter (ex. class="{backgroundColor} m-2") with hover.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
N/A
How to test this PR?
Signed-off-by: Charlie Drage charlie@charliedrage.com