Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): comment out unused code #18

Merged
merged 1 commit into from May 31, 2023

Conversation

BlackHole1
Copy link
Contributor

@BlackHole1 BlackHole1 commented May 30, 2023

http://fresh-center.net/linux/misc/zstd-1.5.2.tar.gz has been invalid.

@BlackHole1 BlackHole1 force-pushed the fix-zstd branch 2 times, most recently from 6b2049e to 2fdf08f Compare May 30, 2023 03:46
@anjannath
Copy link
Member

zstd is not used by the build script, all the dependencies that are built can be found here:

function build_qemu_deps() {
build_lib_gettext "$1"
build_lib_libffi "$1"
build_lib_pcre2 "$1"
# glib should always follow the above dependencies (order matters)
build_lib_glib "$1"
build_lib_gmp "$1"
build_lib_gpgerror "$1"
build_lib_gcrypt "$1"
build_lib_nettle "$1"
build_lib_libpng "$1"
build_lib_jpeg "$1"
build_lib_pixman "$1"
build_lib_libslirp "$1"
build_lib_libusb "$1"
build_lib_lzo "$1"
build_lib_snappy "$1"
build_lib_vde2 "$1"
}

@BlackHole1 BlackHole1 changed the title fix(zstd): download url invalid refactor(deps): comment out unused code May 30, 2023
Signed-off-by: Black-Hole1 <bh@bugs.cc>
@BlackHole1
Copy link
Contributor Author

@anjannath I re-modified the content and title of PR.

Copy link
Member

@anjannath anjannath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@anjannath anjannath merged commit 91bd19c into containers:main May 31, 2023
2 checks passed
@BlackHole1 BlackHole1 deleted the fix-zstd branch May 31, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants