Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Fix docs links due to branch rename #114

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 10, 2021

Ref: containers/common#549

Signed-off-by: Chris Evich cevich@redhat.com

@cevich
Copy link
Member Author

cevich commented Jun 11, 2021

I'm guessing test failure is addressed by #110

This PR is also likely completely safe to force-merge.

@mwhahaha
Copy link
Collaborator

no we don't currently have a fix for CI. i'm trying to take a look at it today but i think the fix is on the podman side not the podman-py side

@cevich
Copy link
Member Author

cevich commented Jun 11, 2021

no we don't currently have a fix for CI

Oh okay, thanks for the correction and update.

@mwhahaha
Copy link
Collaborator

This needs a rebase to pass CI. CI should be good.

Fix the intended destination branch referenced in Cirrus-CI
configuration.

Also update the `latest_podman.sh` script so it won't be sensitive to
`containers/podman` converting master -> main at some future date.

Signed-off-by: Chris Evich <cevich@redhat.com>
Ref: containers/common#549

Signed-off-by: Chris Evich <cevich@redhat.com>
Copy link
Collaborator

@mwhahaha mwhahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mwhahaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwhahaha mwhahaha merged commit fefc036 into containers:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants