Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with container's run method #185

Merged
merged 3 commits into from Jul 7, 2022
Merged

Fix issue with container's run method #185

merged 3 commits into from Jul 7, 2022

Conversation

mrbazzan
Copy link
Contributor

See #102

@mrbazzan mrbazzan force-pushed the container_run branch 2 times, most recently from ae2cd34 to f558b78 Compare June 30, 2022 18:48
@mrbazzan
Copy link
Contributor Author

/assign @rhatdan

@rhatdan
Copy link
Member

rhatdan commented Jul 1, 2022

Looks like this is failing a linting issue?

@mrbazzan
Copy link
Contributor Author

mrbazzan commented Jul 2, 2022

Looks like this is failing a linting issue?

I have no idea why this is failing...I did not touch the mentioned files.

@mrbazzan
Copy link
Contributor Author

mrbazzan commented Jul 2, 2022 •
edited

I have no idea why this is failing...I did not touch the mentioned files.

@rhatdan
I reformatted the podman/api/typing_extensions.py using tox -e black-format, and now the Gating test passes

@rhatdan
Copy link
Member

rhatdan commented Jul 4, 2022

I think you want this to say exited or running. Now it just says wait for the container to exit. Which will cause it to hang for a long time.

@rhatdan rhatdan mentioned this pull request Jul 4, 2022
Merged
@mrbazzan
Copy link
Contributor Author

mrbazzan commented Jul 4, 2022

I think you want this to say exited or running. Now it just says wait for the container to exit. Which will cause it to hang for a long time.

Thanks. I've updated it.
Do you think I should update the .wait() doc in a different commit?

@rhatdan
Copy link
Member

rhatdan commented Jul 4, 2022

Yes SGTM
Does this fix your issue?
/approve
LGTM
@jwhonce @mwhahaha PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbazzan, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 4, 2022
@mrbazzan
Copy link
Contributor Author

mrbazzan commented Jul 4, 2022

Does this fix your issue?

Yes, the first part.

The other issue is this line.
.wait() return an integer which is not subscriptable.

@mrbazzan
Fix black formatter error
76eaf88 
Signed-off-by: Abdulwasiu Apalowo <abdulwasiuapalowo@gmail.com>
@mrbazzan
Update container.wait() doc
4398aea 
Signed-off-by: Abdulwasiu Apalowo <abdulwasiuapalowo@gmail.com>
@mrbazzan
Fix issue with container's run method
c3c7320 
This fixes an issue of PodmanClient hanging for some
commands.

See containers#102

Signed-off-by: Abdulwasiu Apalowo <abdulwasiuapalowo@gmail.com>
@jwhonce
Copy link
Member

jwhonce commented Jul 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 7, 2022
@openshift-ci openshift-ci bot merged commit 619e9e7 into containers:main Jul 7, 2022
@umohnani8 umohnani8 mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jwhonce jwhonce

@rhatdan rhatdan

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrbazzan @rhatdan @jwhonce