Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Packit: use default update_release behavior #393

Merged
merged 1 commit into from
May 23, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 23, 2024

The release needs to be updated if you're building for a persistent copr otherwise you'll end up with multiple builds with no change in the release tag.
See recent builds at: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/package/python-podman/ Ref Build IDs: 7478065, 7455330, 7446571

Packit by default updates the Release in spec file for copr builds which is what we want.

The release needs to be updated if you're building for a persistent
copr otherwise you'll end up with multiple builds with no change in the
release tag.
See recent builds at: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/package/python-podman/
Ref Build IDs: 7478065, 7455330, 7446571

Packit by default updates the Release in spec file for copr builds which
is what we want.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 marked this pull request as ready for review May 23, 2024 15:09
@lsm5
Copy link
Member Author

lsm5 commented May 23, 2024

@inknos PTAL

cc @jwhonce @rhatdan @umohnani8

@inknos
Copy link
Collaborator

inknos commented May 23, 2024

thank you
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d825ccb into containers:main May 23, 2024
14 checks passed
@lsm5 lsm5 deleted the packit-update-release branch May 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants