Add ssh env variables to tox testenv #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For users who have a ssh key protected by passphrase tests can hang and fail on 'Enter passphrase for key' if the correct ssh agent env variable is not set in tox. Signed-off-by: Nicola Sella <nsella@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/packit build |
|
@inknos It looks like your change impacted how ssh connectiions are being parsed. Or did the podman API server change? |
|
no, there must be something wrong. I'll close the PR for now and try to look more in my local env. This looks like being a fix for me only :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users who have a ssh key protected by passphrase tests can hang and fail on 'Enter passphrase for key' if the correct ssh agent env variable is not set in tox.