Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system connections #28

Merged
merged 3 commits into from
Mar 24, 2022
Merged

system connections #28

merged 3 commits into from
Mar 24, 2022

Conversation

navidys
Copy link
Collaborator

@navidys navidys commented Mar 20, 2022

new feature - system connection (ssh, unix and tcp)

  • Similar steps as podman v4 system connections (add, remove, connect, disconnect, set default)
  • Configurtion is saved under ~/.config/podman-tui/podman-tui.conf
  • Before adding new SSH connection validation will be perform (similar to podman v4)
  • Since podman bindings is using pkg/terminal which is writing to stdout and reading from stdin, therefore a bit complicated at the moment to read SSH identity phasephrase from UI, therefore phasepharase shall be set via "CONTAINER_PASSPHRASE" variable otherwise the application will set the OS environment "CONTAINER_PASSPHRASE=empty" and unset after application exits
  • tests update to cover system connections commands
  • docs update

podman-system

Signed-off-by: Navid Yaghoobi <n.yaghoobi.s@gmail.com>
Signed-off-by: Navid Yaghoobi <n.yaghoobi.s@gmail.com>
Signed-off-by: Navid Yaghoobi <n.yaghoobi.s@gmail.com>
@navidys navidys added the enhancement New feature or request label Mar 21, 2022
@navidys navidys merged commit 552b2bc into containers:main Mar 24, 2022
@navidys navidys deleted the system_connections branch March 24, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant