Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting #151

Closed
wants to merge 2 commits into from
Closed

Fix formatting #151

wants to merge 2 commits into from

Conversation

fulldecent
Copy link
Contributor

Following the convention in this file, code typeset is used for commands run in a shell environment.

The macOS Terminal app does not meet this definition, so fixing the typesetting for it.

@TomSweeneyRedHat
Copy link
Member

@fulldecent Thanks for the commit, but our CI requires a signature.

Could you please git commit --amend -s, git fetch, git rebase, git push? Looks like the same issue on your other commit too.

Thanks again,

@fulldecent
Copy link
Contributor Author

Thank you, got it, rebased and signed

@rhatdan
Copy link
Member

rhatdan commented May 31, 2023

The signature did not work?

@fulldecent
Copy link
Contributor Author

Is the other one right?

@TomSweeneyRedHat
Copy link
Member

@fulldecent still doesn't look like it's finding your signature. Did you do a git commit --amend -s, then fetch, rebase and push?

@TomSweeneyRedHat
Copy link
Member

Oh, now I comprehend your question @fulldecent . Yes, your other PR was right, I just merged that thanks!

@TomSweeneyRedHat
Copy link
Member

I think this was fixed in the other PR, so I'm going to close this one. @fulldecent please correct me and reopen if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants