Skip to content

Commit

Permalink
CI: remove build without cgo task
Browse files Browse the repository at this point in the history
Podman is basically unusable without cgo, checking if it compiles
without adds no value and just tricks people into thinking it works when
it does not.

This means we do not need extra to NOP out a lot of cgo calls with
functions that just return an error like `XXX is not supported without
cgo`.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
  • Loading branch information
Luap99 authored and ashley-cui committed Jul 20, 2023
1 parent 598ebe8 commit 0115a48
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,6 @@ alt_build_task:
ALT_NAME: 'Build Each Commit'
- env:
ALT_NAME: 'Windows Cross'
- env:
ALT_NAME: 'Build Without CGO'
- env:
ALT_NAME: 'Alt Arch. Cross'
- env:
Expand Down
7 changes: 0 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -446,13 +446,6 @@ local-cross: $(CROSS_BUILD_TARGETS) ## Cross compile podman binary for multiple
.PHONY: cross
cross: local-cross

.PHONY: build-no-cgo
build-no-cgo:
BUILDTAGS="containers_image_openpgp exclude_graphdriver_btrfs \
exclude_graphdriver_devicemapper exclude_disk_quota" \
CGO_ENABLED=0 \
$(MAKE) all

.PHONY: completions
completions: podman podman-remote
# key = shell, value = completion filename
Expand Down
3 changes: 0 additions & 3 deletions contrib/cirrus/runner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,6 @@ function _run_altbuild() {
make podman-remote-release-windows_amd64.zip
make podman.msi
;;
*Without*)
make build-no-cgo
;;
*RPM*)
make package
;;
Expand Down

0 comments on commit 0115a48

Please sign in to comment.