Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-remote build --iidfile : spurious "Copying config" appears in iidfile #10233

Closed
edsantiago opened this issue May 5, 2021 · 3 comments · Fixed by #10242
Closed

podman-remote build --iidfile : spurious "Copying config" appears in iidfile #10233

edsantiago opened this issue May 5, 2021 · 3 comments · Fixed by #10242
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Collaborator

Please bear with me, I realize this is weird. Every so often, podman-remote build, with just the right set of flags, writes an unwanted "Copying config" into the iidfile:

In window 1:

$ podman system service --timeout=0

In window 2:

$ cat Containerfile
FROM scratch
$ while :;do ../bin/podman-remote build --layers=false --force-rm=false --iidfile /tmp/foo.iid -t scratch-image .;grep Copying /tmp/foo.iid && break;../bin/podman rmi scratch-image;done
STEP 1: FROM scratch
STEP 2: COMMIT scratch-image
Getting image source signatures
Copying blob sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef
Copying config sha256:5eb5601aaca27b05615d6fb9a7ff44692ee79d4ab4ea5e2ce9726ed95853a577
Writing manifest to image destination
Storing signatures
--> 5eb5601aaca
Successfully tagged localhost/scratch-image:latest
sha256:Copying config sha256:5eb5601aaca27b05615d6fb9a7ff44692ee79d4ab4ea5e2ce9726ed95853a577

(Expected: just sha256:5eb...., without Copying config)

It does not happen with non-remote podman. It does not happen without --layers=false --force-rm=false. Even with all these flags and settings, it sometimes takes 2-3 repeats to fail.
@edsantiago edsantiago added flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels May 5, 2021
@edsantiago
Copy link
Collaborator Author

Sample failure, seen in my buildah-bud + podman-remote PR

@rhatdan
Copy link
Member

rhatdan commented May 5, 2021

You love to find the weird ones. :^)

giuseppe added a commit to giuseppe/libpod that referenced this issue May 6, 2021
@giuseppe
build: improve regex for iidfile
68accbf 
improve the regex to match only at the beginning of the line.

It prevents matching "Copying %s $CHECKSUM" messages returned by the
containers/image copy process.

Closes: containers#10233

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue May 6, 2021
Merged
@giuseppe
Copy link
Member

giuseppe commented May 6, 2021

PR here: #10242

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: improve regex for iidfile giuseppe/libpod
3 participants
@giuseppe @edsantiago @rhatdan