-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman inspect
returns State.Healthcheck
when docker
uses State.Health
#11645
Labels
In Progress
This issue is actively being worked by the assignee, please do not work on this at this time.
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
abitrolly
added a commit
to abitrolly/warehouse
that referenced
this issue
Sep 18, 2021
Luap99
added
the
In Progress
This issue is actively being worked by the assignee, please do not work on this at this time.
label
Sep 20, 2021
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Sep 20, 2021
podman inspect shows the healthcheck status in `.State.Healthcheck`, docker uses `.State.Health`. To make sure docker scripts work we should add the `Health` field and since we should not break existing users of the `Healthcheck` field, we show both fields. While this is redundant, it is better than breaking users. Fixes containers#11645 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Is it ok for you to only add |
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Sep 21, 2021
podman inspect shows the healthcheck status in `.State.Healthcheck`, docker uses `.State.Health`. To make sure docker scripts work we should add the `Health` key as method. This will return the same as Healthcheck but is not displayed by default in the inspect output. But if a users uses `--format {{.State.Health}}` it works now. Fixes containers#11645 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 not really. The reason I spotted this is because I was developing my scripts with |
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Sep 22, 2021
podman inspect shows the healthcheck status in `.State.Healthcheck`, docker uses `.State.Health`. To make sure docker scripts work we should add the `Health` key. Because we do not want to display both keys by default we only use the new `Health` key. This is a breaking change for podman users but matches what docker does. To provide some form of compatibility users can still use `--format {{.State.Healthcheck}}`. IT is just not shown by default. Fixes containers#11645 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Sep 22, 2021
podman inspect shows the healthcheck status in `.State.Healthcheck`, docker uses `.State.Health`. To make sure docker scripts work we should add the `Health` key. Because we do not want to display both keys by default we only use the new `Health` key. This is a breaking change for podman users but matches what docker does. To provide some form of compatibility users can still use `--format {{.State.Healthcheck}}`. IT is just not shown by default. Fixes containers#11645 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Sep 22, 2021
podman inspect shows the healthcheck status in `.State.Healthcheck`, docker uses `.State.Health`. To make sure docker scripts work we should add the `Health` key. Because we do not want to display both keys by default we only use the new `Health` key. This is a breaking change for podman users but matches what docker does. To provide some form of compatibility users can still use `--format {{.State.Healthcheck}}`. IT is just not shown by default. Fixes containers#11645 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Sep 23, 2021
podman inspect shows the healthcheck status in `.State.Healthcheck`, docker uses `.State.Health`. To make sure docker scripts work we should add the `Health` key. Because we do not want to display both keys by default we only use the new `Health` key. This is a breaking change for podman users but matches what docker does. To provide some form of compatibility users can still use `--format {{.State.Healthcheck}}`. IT is just not shown by default. Fixes containers#11645 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
openstack-mirroring
pushed a commit
to openstack-archive/tripleo-heat-templates
that referenced
this issue
Sep 20, 2023
This patch makes container healthcheck work also with versions of podman(-remote) lower than 4.0.0. For more infor please check [1]. [1] containers/podman#11645 Resolves: rhbz#2223294 Change-Id: I4acdb425f19802424800876c11838364b623bc07
github-actions
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
In Progress
This issue is actively being worked by the assignee, please do not work on this at this time.
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
/kind bug
Description
Scripts that check health of containers are incompatible between
docker
andpodman
.Steps to reproduce the issue:
docker
podman
and inspect it as well.Describe the results you received:
podman
usesState.Healthcheck,Status
docker
usesState.Health.Status
Describe the results you expected:
Both use
State.Health.Status
.Output of
podman version
:Additional environment details (AWS, VirtualBox, physical, etc.):
The text was updated successfully, but these errors were encountered: