Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustable machine proxy port #11728

Closed
swartz-k opened this issue Sep 24, 2021 · 5 comments · Fixed by #12283
Closed

Adjustable machine proxy port #11728

swartz-k opened this issue Sep 24, 2021 · 5 comments · Fixed by #12283
Assignees
@Luap99
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine

Comments

@swartz-k
Copy link

swartz-k commented Sep 24, 2021 •
edited
Loading

Maybe this can be adjustable? In my env, I have already an daemon service listen on 7777, so there will be error

podman/pkg/machine/qemu/machine.go

Line 646 in 1dba601

listenSocket := "tcp://0.0.0.0:7777"

@Luap99
Copy link
Member

Luap99 commented Sep 24, 2021

I think containers/gvisor-tap-vsock#46 should fix the problem. With this we would not need bind a port at all.

@Luap99 Luap99 added kind/bug Categorizes issue or PR as related to a bug. machine labels Sep 24, 2021
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Oct 25, 2021

@Luap99 since this is merged can we close this issue, or is there a change required in Podman?

@Luap99
Copy link
Member

Luap99 commented Oct 25, 2021

It needs to be changed in podman as well

@rhatdan
Copy link
Member

rhatdan commented Oct 26, 2021

@Luap99 Could you make the change in Podman to complete it.

This was referenced Nov 6, 2021
Closed
Closed
@Luap99 Luap99 added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Nov 12, 2021
@Luap99 Luap99 self-assigned this Nov 12, 2021
Luap99 added a commit to Luap99/libpod that referenced this issue Nov 12, 2021
@Luap99
podman machine improve port forwarding
b713bb6 
This commits adds port forwarding logic directly into podman. The
podman-machine cni plugin is no longer needed.

The following new features are supported:
 - works with cni, netavark and slirp4netns
 - ports can use the hostIP to bind instead of hard coding 0.0.0.0
 - gvproxy no longer listens on 0.0.0.0:7777 (requires a new gvproxy
   version)
 - support the udp protocol

With this we no longer need podman-machine-cni and should remove it from
the packaging. There is also a change to make sure we are backwards
compatible with old config which include this plugin.

Fixes containers#11528
Fixes containers#11728

[NO NEW TESTS NEEDED] We have no podman machine test at the moment.
Please test this manually on your system.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Nov 12, 2021
@Luap99
podman machine improve port forwarding
852898d 
This commits adds port forwarding logic directly into podman. The
podman-machine cni plugin is no longer needed.

The following new features are supported:
 - works with cni, netavark and slirp4netns
 - ports can use the hostIP to bind instead of hard coding 0.0.0.0
 - gvproxy no longer listens on 0.0.0.0:7777 (requires a new gvproxy
   version)
 - support the udp protocol

With this we no longer need podman-machine-cni and should remove it from
the packaging. There is also a change to make sure we are backwards
compatible with old config which include this plugin.

Fixes containers#11528
Fixes containers#11728

[NO NEW TESTS NEEDED] We have no podman machine test at the moment.
Please test this manually on your system.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Nov 12, 2021
Merged
Luap99 added a commit to Luap99/libpod that referenced this issue Nov 12, 2021
@Luap99
podman machine improve port forwarding
0ba4e65 
This commits adds port forwarding logic directly into podman. The
podman-machine cni plugin is no longer needed.

The following new features are supported:
 - works with cni, netavark and slirp4netns
 - ports can use the hostIP to bind instead of hard coding 0.0.0.0
 - gvproxy no longer listens on 0.0.0.0:7777 (requires a new gvproxy
   version)
 - support the udp protocol

With this we no longer need podman-machine-cni and should remove it from
the packaging. There is also a change to make sure we are backwards
compatible with old config which include this plugin.

Fixes containers#11528
Fixes containers#11728

[NO NEW TESTS NEEDED] We have no podman machine test at the moment.
Please test this manually on your system.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Nov 15, 2021
@Luap99
podman machine improve port forwarding
295d87b 
This commits adds port forwarding logic directly into podman. The
podman-machine cni plugin is no longer needed.

The following new features are supported:
 - works with cni, netavark and slirp4netns
 - ports can use the hostIP to bind instead of hard coding 0.0.0.0
 - gvproxy no longer listens on 0.0.0.0:7777 (requires a new gvproxy
   version)
 - support the udp protocol

With this we no longer need podman-machine-cni and should remove it from
the packaging. There is also a change to make sure we are backwards
compatible with old config which include this plugin.

Fixes containers#11528
Fixes containers#11728

[NO NEW TESTS NEEDED] We have no podman machine test at the moment.
Please test this manually on your system.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

podman machine improve port forwarding Luap99/libpod
Fixes #11728 Remove gvproxy listen argument
3 participants
@rhatdan @Luap99 @swartz-k