Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podman search should return the entire description in the --format json #11894

Closed
rhatdan opened this issue Oct 8, 2021 · 1 comment · Fixed by #11924
Closed

Podman search should return the entire description in the --format json #11894

rhatdan opened this issue Oct 8, 2021 · 1 comment · Fixed by #11924
Assignees
@jwhonce
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@rhatdan
Copy link
Member

rhatdan commented Oct 8, 2021

Currently podman search is truncating on the server side, while I believe it should be on the client side.

Currently in order to get the fully description of an image, I have to execute
podman search --no-trunc --format json XYZ
This should happen by default.

Also if we are cleaning up the podman search command, I believe it should be showing me as much description as can show up in the tty, unless I put in another column in the display.

Truncating the description by default seems to ruin the reason I run search.

Final idea would be to add a pager to podman search.

So it would be easy to page up and down and left and write when I run it on a tty.
This would be the equivalent of a podman search --notrunc XYZ | less.
@mheon mheon added the kind/bug Categorizes issue or PR as related to a bug. label Oct 8, 2021
@jwhonce jwhonce self-assigned this Oct 11, 2021
@jwhonce jwhonce added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Oct 11, 2021
@jwhonce
Copy link
Member

jwhonce commented Oct 11, 2021

@rhatdan

  1. Terminal width is not included in PR because we do not know the width of the text before the description field, the template and tabwriter objects abstract that information away from us.
  2. Cross-platform pagination will require some research, so I did not include it in the associated PR.

jwhonce added a commit to jwhonce/podman that referenced this issue Oct 11, 2021
@jwhonce
Refactor podman search to be more code friendly
7bbc563 
[No New Tests Needed]

* JSON and API description fields are no longer truncated. Formatting
  moved to client, better support of MVP.
* --no-trunc now defaults to true

Closes containers#11894

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@jwhonce jwhonce mentioned this issue Oct 11, 2021
Merged
jwhonce added a commit to jwhonce/podman that referenced this issue Oct 12, 2021
@jwhonce
Refactor podman search to be more code friendly
b28a8bc 
* JSON and API description fields are no longer truncated. Formatting
  moved to client, better support of MVP.
* --no-trunc now defaults to true
* Updated tests for changes

Closes containers#11894

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@vrothberg vrothberg mentioned this issue Apr 28, 2022
Closed
@flouthoc flouthoc mentioned this issue Apr 28, 2022
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jwhonce jwhonce

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor podman search to be more code friendly jwhonce/podman
3 participants
@jwhonce @rhatdan @mheon