Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play kube: brings in unwanted k8s pause #12254

Closed
edsantiago opened this issue Nov 10, 2021 · 4 comments · Fixed by #12280
Closed

play kube: brings in unwanted k8s pause #12254

edsantiago opened this issue Nov 10, 2021 · 4 comments · Fixed by #12280
Assignees
@vrothberg
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Collaborator

IIUC the world has changed, and pods no longer need k8s/pause. podman play kube fetches it anyway:

$ bin/podman images
REPOSITORY  TAG         IMAGE ID    CREATED     SIZE
$ printf "apiVersion: v1\nkind: Pod\nmetadata:\n  name: foo\n" | env CONTAINER_HELPER_PAUSE_PAUSE=bin/pause bin/podman play kube -
Pod:
738622313f1f37b32814664a8dc86d2df36dd5036e661e1d15623686e26c2616
$ bin/podman images
REPOSITORY              TAG                   IMAGE ID      CREATED        SIZE
localhost/podman-pause  4.0.0-dev-1636547894  99f3b83b4245  5 seconds ago  1.65 MB
k8s.gcr.io/pause        3.5                   ed210e3e4a5b  7 months ago   690 kB

I expected to see localhost/podman-pause; did not expect to see the k8s one.

main @ 5437568
@rhatdan
Copy link
Member

rhatdan commented Nov 10, 2021

@vrothberg PTAL

podman/pkg/domain/infra/abi/play.go is pulling the image.

@vrothberg vrothberg self-assigned this Nov 12, 2021
vrothberg added a commit to vrothberg/libpod that referenced this issue Nov 12, 2021
@vrothberg
play kube: don't force-pull infra image
f517510 
Do not force-pull the infra image in `play kube` but let the backend
take care of that when creating the pod(s) which may build a local
`podman-pause` image instead of using the default infra image.

Fixes: containers#12254
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg vrothberg mentioned this issue Nov 12, 2021
Merged
@vrothberg
Copy link
Member

Thanks for the report and the ping.

Here's a PR to fix the issue: #12280

@setharnold
Copy link

Hello, was a CVE assigned for this issue? Thanks

@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2023

No

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

play kube: don't force-pull infra image vrothberg/libpod
4 participants
@edsantiago @rhatdan @setharnold @vrothberg