Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent host.containers.internal entry inside container #13224

Closed
vikas-goel opened this issue Feb 13, 2022 · 7 comments · Fixed by #13918
Closed

Prevent host.containers.internal entry inside container #13224

vikas-goel opened this issue Feb 13, 2022 · 7 comments · Fixed by #13918
Assignees
@Luap99
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. network Networking related issue or feature

Comments

@vikas-goel
Copy link
Contributor

vikas-goel commented Feb 13, 2022 •
edited

/kind feature

Description

Podman adds host.containers.internal entry, that maps to the host’s IP address, in containers /etc/hosts file automatically. The containers are connected to macvlan networks. This entry is not desired and behavior is different from Docker.

How can it be prevented?

Steps to reproduce the issue:

  1. Start a container with macvlan network.

  2. Check /etc/hosts file inside container

Describe the results you received:

host.containers.internal mapped to host’s IP address

Describe the results you expected:

No such entry should be present

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Podman 4.0RC* mainline

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes

Additional environment details (AWS, VirtualBox, physical, etc.):

RHEL8.5
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2022
@Luap99
Copy link
Member

Luap99 commented Feb 14, 2022

Is there any specific reason why we should not add this? #12807 changed this so that we the correct host ip address instead of the macvlan gateway.

@Luap99 Luap99 added the network Networking related issue or feature label Feb 14, 2022
@vikas-goel
Copy link
Contributor Author

What is the use-case of host.containers.internal inside containers with macvlan networks only?

The only concern is about exposing the host IP address inside the containers. My ask is to not add this entry altogether.

@Luap99
Copy link
Member

Luap99 commented Feb 15, 2022

host.container.internal is added for bridge and slirp4netns as well

@vikas-goel
Copy link
Contributor Author

That makes sense for the two interface types. In case of macvlan, how I can avoid leaking the host IP to containers that works with Docker Compose?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@Luap99
Copy link
Member

Luap99 commented Mar 18, 2022 •
edited

@vikas-goel Would a containers.conf option work for you?

@vikas-goel
Copy link
Contributor Author

Yes.

@Luap99 Luap99 self-assigned this Apr 7, 2022
Luap99 added a commit to Luap99/common that referenced this issue Apr 11, 2022
@Luap99
add host_containers_internal_ip to containers.conf
fbb9e01 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Apr 11, 2022
Merged
Luap99 added a commit to Luap99/common that referenced this issue Apr 11, 2022
@Luap99
add host_containers_internal_ip to containers.conf
c4edfc0 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 11, 2022
@Luap99
add host_containers_internal_ip to containers.conf
2ae0c6d 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 12, 2022
@Luap99
add host_containers_internal_ip to containers.conf
1bf2f66 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 12, 2022
@Luap99
add host_containers_internal_ip to containers.conf
ea42a4a 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 14, 2022
@Luap99
add host_containers_internal_ip to containers.conf
bf9933f 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 14, 2022
@Luap99
add host_containers_internal_ip to containers.conf
6fd0cbe 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 19, 2022
@Luap99
add host_containers_internal_ip to containers.conf
67f3476 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/common that referenced this issue Apr 19, 2022
@Luap99
add host_containers_internal_ip to containers.conf
85bda3a 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Apr 19, 2022
@Luap99
use etchosts package from c/common
beca64b 
Use the new logic from c/common to create the hosts file. This will help
to better allign the hosts files between buildah and podman.

Also this fixes several bugs:
- remove host entries when container is stopped and has a netNsCtr
- add entries for containers in a pod
- do not duplicate entries in the hosts file
- use the correct slirp ip when an userns is used

Features:
- configure host.containers.internal entry in containers.conf
- configure base hosts file in containers.conf

Fixes containers#12003
Fixes containers#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Apr 19, 2022
Merged
Luap99 added a commit to Luap99/common that referenced this issue Apr 21, 2022
@Luap99
add host_containers_internal_ip to containers.conf
5648492 
Set the ip for the host.containers.internal entry in the containers /etc/hosts
file. This can be set to "none" to disable adding this entry. By default it
will automatically choose the host ip.

Also add a function to get the correct host.containers.internal ip. This
should be used by podman and buildah and then passed to the New()
function.

Ref containers/podman#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Apr 21, 2022
@Luap99
use etchosts package from c/common
9d1795a 
Use the new logic from c/common to create the hosts file. This will help
to better allign the hosts files between buildah and podman.

Also this fixes several bugs:
- remove host entries when container is stopped and has a netNsCtr
- add entries for containers in a pod
- do not duplicate entries in the hosts file
- use the correct slirp ip when an userns is used

Features:
- configure host.containers.internal entry in containers.conf
- configure base hosts file in containers.conf

Fixes containers#12003
Fixes containers#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Apr 21, 2022
@Luap99
use etchosts package from c/common
f997fb2 
Use the new logic from c/common to create the hosts file. This will help
to better allign the hosts files between buildah and podman.

Also this fixes several bugs:
- remove host entries when container is stopped and has a netNsCtr
- add entries for containers in a pod
- do not duplicate entries in the hosts file
- use the correct slirp ip when an userns is used

Features:
- configure host.containers.internal entry in containers.conf
- configure base hosts file in containers.conf

Fixes containers#12003
Fixes containers#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Apr 21, 2022
@Luap99
use etchosts package from c/common
7fd35ab 
Use the new logic from c/common to create the hosts file. This will help
to better allign the hosts files between buildah and podman.

Also this fixes several bugs:
- remove host entries when container is stopped and has a netNsCtr
- add entries for containers in a pod
- do not duplicate entries in the hosts file
- use the correct slirp ip when an userns is used

Features:
- configure host.containers.internal entry in containers.conf
- configure base hosts file in containers.conf

Fixes containers#12003
Fixes containers#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Apr 22, 2022
@Luap99
use etchosts package from c/common
696bcd2 
Use the new logic from c/common to create the hosts file. This will help
to better allign the hosts files between buildah and podman.

Also this fixes several bugs:
- remove host entries when container is stopped and has a netNsCtr
- add entries for containers in a pod
- do not duplicate entries in the hosts file
- use the correct slirp ip when an userns is used

Features:
- configure host.containers.internal entry in containers.conf
- configure base hosts file in containers.conf

Fixes containers#12003
Fixes containers#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
gbraad pushed a commit to gbraad-redhat/podman that referenced this issue Jul 13, 2022
@Luap99
use etchosts package from c/common
95ca781 
Use the new logic from c/common to create the hosts file. This will help
to better allign the hosts files between buildah and podman.

Also this fixes several bugs:
- remove host entries when container is stopped and has a netNsCtr
- add entries for containers in a pod
- do not duplicate entries in the hosts file
- use the correct slirp ip when an userns is used

Features:
- configure host.containers.internal entry in containers.conf
- configure base hosts file in containers.conf

Fixes containers#12003
Fixes containers#13224

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. network Networking related issue or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use etchosts package from c/common Luap99/libpod
2 participants
@vikas-goel @Luap99