Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot remove container: error sending SIGKILL #15661

Closed
edsantiago opened this issue Sep 6, 2022 · 3 comments · Fixed by #15716
Closed

cannot remove container: error sending SIGKILL #15661

edsantiago opened this issue Sep 6, 2022 · 3 comments · Fixed by #15716
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Collaborator

New (to me) flake seen in remote f36 aarch64 root

# podman-remote  rm -t 0 -f cpcontainer
Error: cannot remove container <sha> as it could not be stopped: \
     error sending SIGKILL to container <same sha>: %!w(<nil>)

(line break and edits for readability). (the percent-bang-double-u-nil is verbatim.)

Unlike #15367, this did NOT leave the system hosed. It failed, but all subsequent tests passed.
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Sep 6, 2022
@vrothberg
Copy link
Member

Thanks, @edsantiago! Is it remote only so far?

@edsantiago
Copy link
Collaborator Author

No, here's a local-podman one: int f36 root. Another remote: int remote ubuntu 2204 root. Both of those in the podman run network connection with default bridge test, which is suspicious.

Only three instances in my logs. First one is the ubuntu one, August 2. This is going to be a hard one to track, because it only triggers a CI failure in sys tests, not int (because int tests do not do error-checking on cleanup).

vrothberg added a commit to vrothberg/libpod that referenced this issue Sep 9, 2022
@vrothberg
stop: fix error handling
9c479bf 
Fix the error handling in the fallback logic of `stop` when Podman
resorts to killing a container.  There was missing `nil` check in
which case Podman mistakenly returned an error.

[NO NEW TESTS NEEDED] as it is a rare flake in the tests and I do not
know how to reliably reproduce it.

Fixes: containers#15661
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg vrothberg mentioned this issue Sep 9, 2022
Merged
@vrothberg
Copy link
Member

Turned out to be an easy fix #15716.

vrothberg added a commit to vrothberg/libpod that referenced this issue Sep 9, 2022
@vrothberg
stop: fix error handling
6bf8670 
Fix the error handling in the fallback logic of `stop` when Podman
resorts to killing a container; the error message wrapped the wrong
error.

[NO NEW TESTS NEEDED] as it is a rare flake in the tests and I do not
know how to reliably reproduce it.

Fixes: containers#15661
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop: fix error handling vrothberg/libpod
2 participants
@edsantiago @vrothberg