Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Flake: podman system prune networks: expected string length 1 #15990

Closed
edsantiago opened this issue Sep 29, 2022 · 1 comment · Fixed by #15994
Closed

CI Flake: podman system prune networks: expected string length 1 #15990

edsantiago opened this issue Sep 29, 2022 · 1 comment · Fixed by #15994
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Collaborator

This probably falls under #14173, but it's hitting us hard so it deserves extra scrutiny:

           podman system prune networks
...
? Failure [2.724 seconds]
         Podman prune
         /var/tmp/go/src/github.com[/containers/podman/test/e2e/prune_test.go:24](https://github.com/containers/podman/blob/0fb95f95d2af7bcc2529f896fec9904b3357b580/test/e2e/prune_test.go#L24)
           podman system prune networks [It]
           /var/tmp/go/src/github.com[/containers/podman/test/e2e/prune_test.go:261](https://github.com/containers/podman/blob/0fb95f95d2af7bcc2529f896fec9904b3357b580/test/e2e/prune_test.go#L261)
         
           Expected
               <[]string | len:0, cap:0>: nil
           to have length 1

Podman prune [It] podman system prune networks
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Sep 29, 2022
@Luap99
Copy link
Member

Luap99 commented Sep 29, 2022

This is not related to #14173 in any way.

Given that this is a flake I suspect the problem is in the test and not podman. The test uses a shared network config dir so any other parallel running test could remove it and cause this test to flake.

Luap99 added a commit to Luap99/libpod that referenced this issue Sep 29, 2022
@Luap99
fix "podman system prune networks" flake
e48808f 
Since by default the network config dir is share din the e2e tests any
other parallel running test could remove a network and cause our test to
fail.

Fixes containers#15990

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Sep 29, 2022
@Luap99
fix "podman system prune networks" flake
3b5171d 
Since by default the network config dir is shared in the e2e tests any
other parallel running test could remove a network and cause this test to
fail.

Fixes containers#15990

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Sep 29, 2022
Merged
iamkirkbater pushed a commit to iamkirkbater/podman that referenced this issue Oct 5, 2022
@Luap99 @iamkirkbater
fix "podman system prune networks" flake
1a61647 
Since by default the network config dir is shared in the e2e tests any
other parallel running test could remove a network and cause this test to
fail.

Fixes containers#15990

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix "podman system prune networks" flake Luap99/libpod
2 participants
@edsantiago @Luap99