podman system df does not seem to report actual disk usage #16135
Labels
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
|
Thanks, @sjug! I recall some fixes in the past that went into the image-size calculation but need to track it down. |
|
I bet Podman's calculating images more than once. |
|
Please try with the latest version. I recall some fixes related to that. |
|
No need to check the latest version IMO. No changes were made there in libimage. But what Podman is counting is the sum of the image sizes which can exceed the total disk size given images can share layers. |
|
That's at least my guess. The reports try to calculate that out but I bet there's a fart. |
|
@sjug can you share the output of |
|
Ok, I found an easy reproducer: That doesn't add up and the reported sizes in |
|
vrothberg
added a commit
to vrothberg/common
that referenced
this issue
Oct 17, 2022
Add an API to query the sum of the layer sizes. This data is needed to fix containers/podman/issues/16135. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
added a commit
to vrothberg/common
that referenced
this issue
Oct 17, 2022
Add an API to query the sum of the layer sizes. This data is needed to fix containers/podman/issues/16135. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
|
Still need to do the plumbing in podman. |
vrothberg
added a commit
to vrothberg/libpod
that referenced
this issue
Oct 18, 2022
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
Fixes: containers#16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this issue
Oct 18, 2022
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
Fixes: containers#16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this issue
Oct 18, 2022
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
Fixes: containers#16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this issue
Oct 19, 2022
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
Fixes: containers#16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this issue
Oct 19, 2022
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
NOTE: The c/storage version is pinned back to the previous commit as it
is buggy. c/common already requires the buggy version, so use a
`replace` to force/pin.
Fixes: containers#16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
podman system dfdoesn't show actual disk usage of container images.Looking to find the actual disk usage of the images on disk I tried the
podman system dfcommand.The image size output was 50% larger than my entire virtual disk.
Steps to reproduce the issue:
Pull many images that have common bases. I installed SNO on a VM with a 20G disk.
Check
podman system dfSee actual disk usage of images
Describe the results you received:
The size of images reported vastly exceeds disk capacity.
Describe the results you expected:
Actual disk usage information.
Additional information you deem important (e.g. issue happens only occasionally):
Output of
podman version:Output of
podman info:Package info (e.g. output of
rpm -q podmanorapt list podmanorbrew info podman):Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)
No, this is the latest version shipped with OCP. I tried to reproduce on a different host with RHEL 8.6 and podman 4.1.1; it seemed to still report disk usage the same way.
Additional environment details (AWS, VirtualBox, physical, etc.):
libvirt VM
The text was updated successfully, but these errors were encountered: