manifest push fails with non-docker transports

[hdonnay]

Issue Description

The man page explicitly says:

DESTINATION
       The DESTINATION is a location to store container images
        The Image "DESTINATION" uses a "transport":"details" format.
        If a transport is not given, podman push will attempt to push
        to a registry.

       Multiple transports are supported:

yet:

% podman manifest push --all --remove-signatures quay.io/projectquay/golang:1.20 dir:test                                     
Error: adding to manifest list quay.io/projectquay/golang:1.20: unsupported transport dir in "dir:test": only docker transport is supported

Steps to reproduce the issue

Steps to reproduce the issue

1. Build manifest
2. Attempt to push manifest to a dir transport

Describe the results you received

unsupported transport dir in "dir:test": only docker transport is supported

Describe the results you expected

Working as documented

podman info output

host:
  arch: amd64
  buildahVersion: 1.29.0
  cgroupControllers:
  - cpu
  - io
  - memory
  - pids
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.1.5-1.fc37.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.1.5, commit: '
  cpuUtilization:
    idlePercent: 96.72
    systemPercent: 0.87
    userPercent: 2.41
  cpus: 16
  distribution:
    distribution: fedora
    variant: silverblue
    version: "37"
  eventLogger: journald
  hostname: rot
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  kernel: 6.1.10-200.fc37.x86_64
  linkmode: dynamic
  logDriver: journald
  memFree: 5461020672
  memTotal: 67118391296
  networkBackend: netavark
  ociRuntime:
    name: crun
    package: crun-1.8-1.fc37.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 1.8
      commit: 0356bf4aff9a133d655dc13b1d9ac9424706cac4
      rundir: /run/user/1000/crun
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +LIBKRUN +WASM:wasmedge +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: /run/user/1000/podman/podman.sock
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID
    rootless: true
    seccompEnabled: true
    seccompProfilePath: /usr/share/containers/seccomp.json
    selinuxEnabled: true
  serviceIsRemote: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.2.0-8.fc37.x86_64
    version: |-
      slirp4netns version 1.2.0
      commit: 656041d45cfca7a4176f6b7eed9e4fe6c11e8383
      libslirp: 4.7.0
      SLIRP_CONFIG_VERSION_MAX: 4
      libseccomp: 2.5.3
  swapFree: 5583663104
  swapTotal: 8589930496
  uptime: 1674h 51m 25.00s (Approximately 69.75 days)
plugins:
  authorization: null
  log:
  - k8s-file
  - none
  - passthrough
  - journald
  network:
  - bridge
  - macvlan
  volume:
  - local
registries: {}
store:
  configFile: /var/home/hank/.config/containers/storage.conf
  containerStore:
    number: 4
    paused: 0
    running: 3
    stopped: 1
  graphDriverName: overlay
  graphOptions: {}
  graphRoot: /home/hank/.local/share/containers/storage
  graphRootAllocated: 1020340994048
  graphRootUsed: 210333614080
  graphStatus:
    Backing Filesystem: btrfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageCopyTmpDir: /var/tmp
  imageStore:
    number: 267
  runRoot: /run/user/1000/containers
  transientStore: false
  volumePath: /home/hank/.local/share/containers/storage/volumes
version:
  APIVersion: 4.4.1
  Built: 1675940333
  BuiltTime: Thu Feb  9 10:58:53 2023
  GitCommit: ""
  GoVersion: go1.19.5
  Os: linux
  OsArch: linux/amd64
  Version: 4.4.1

### Podman in a container

No

### Privileged Or Rootless

Rootless

### Upstream Latest Release

No

### Additional environment details

_No response_

### Additional information

_No response_

[Luap99]

I am assume you are using podman machine or podman-remote? Looking in the code this error message only appears in the remote API so I guess this feature is only supported locally.

[hdonnay]

Yes, I've got CONTAINER_HOST set inside my toolbox.

[flouthoc]

@hdonnay Do you expect push to be generated on host side or the client side. There is always a confusion from users when export is happening to a directory. I expect exported directory to be generated on the client side.

[hdonnay]

The client side, just like I don't expect build to reference server paths.

[vrothberg]

Removing the bug label as this behavior is intended. Also podman push does not support any non-docker archives. The intention is to prevent clients from writing on the server side.

For podman push, I recommend using podman save instead. For podman manifest push, there is no real plumbing in save for that I think.

[hdonnay]

I'd argue this is still a bug because it does not behave as documented. Whether it's a bug in manifest push or the documentation is up to you all.

[rhatdan]

Please open a PR to fix the documentation.

[vrothberg]

Note that the man pages mention that the docker transport is the only supported one for remote clients. For push, I opened #18871 to avoid confusion on the main description.

[vrothberg]

Note that the man pages mention that the docker transport is the only supported one for remote clients. For push, I opened #18871 to avoid confusion on the main description.

The manifest push one was actually incomplete, so I addressed that now.