Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest push fails when following example #18360

Closed
hdonnay opened this issue Apr 26, 2023 · 3 comments · Fixed by #18395
Closed

manifest push fails when following example #18360

hdonnay opened this issue Apr 26, 2023 · 3 comments · Fixed by #18395
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@hdonnay
Copy link

hdonnay commented Apr 26, 2023

Issue Description

The example commands in podman-manifest(1) fail at the push step:

Error: accepts 2 arg(s), received 1

Steps to reproduce the issue

Steps to reproduce the issue

  1. podman tag localhost/shazam example.com/example/shazam
  2. podman manifest rm localhost/shazam
  3. podman manifest push --all example.com/example/shazam

Describe the results you received

Error: accepts 2 arg(s), received 1
``

### Describe the results you expected

No error

### podman info output

```yaml
host:
  arch: amd64
  buildahVersion: 1.29.0
  cgroupControllers:
  - cpu
  - io
  - memory
  - pids
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.1.5-1.fc37.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.1.5, commit: '
  cpuUtilization:
    idlePercent: 96.72
    systemPercent: 0.87
    userPercent: 2.41
  cpus: 16
  distribution:
    distribution: fedora
    variant: silverblue
    version: "37"
  eventLogger: journald
  hostname: rot
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  kernel: 6.1.10-200.fc37.x86_64
  linkmode: dynamic
  logDriver: journald
  memFree: 5461020672
  memTotal: 67118391296
  networkBackend: netavark
  ociRuntime:
    name: crun
    package: crun-1.8-1.fc37.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 1.8
      commit: 0356bf4aff9a133d655dc13b1d9ac9424706cac4
      rundir: /run/user/1000/crun
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +LIBKRUN +WASM:wasmedge +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: /run/user/1000/podman/podman.sock
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID
    rootless: true
    seccompEnabled: true
    seccompProfilePath: /usr/share/containers/seccomp.json
    selinuxEnabled: true
  serviceIsRemote: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.2.0-8.fc37.x86_64
    version: |-
      slirp4netns version 1.2.0
      commit: 656041d45cfca7a4176f6b7eed9e4fe6c11e8383
      libslirp: 4.7.0
      SLIRP_CONFIG_VERSION_MAX: 4
      libseccomp: 2.5.3
  swapFree: 5583663104
  swapTotal: 8589930496
  uptime: 1674h 51m 25.00s (Approximately 69.75 days)
plugins:
  authorization: null
  log:
  - k8s-file
  - none
  - passthrough
  - journald
  network:
  - bridge
  - macvlan
  volume:
  - local
registries: {}
store:
  configFile: /var/home/hank/.config/containers/storage.conf
  containerStore:
    number: 4
    paused: 0
    running: 3
    stopped: 1
  graphDriverName: overlay
  graphOptions: {}
  graphRoot: /home/hank/.local/share/containers/storage
  graphRootAllocated: 1020340994048
  graphRootUsed: 210333614080
  graphStatus:
    Backing Filesystem: btrfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageCopyTmpDir: /var/tmp
  imageStore:
    number: 267
  runRoot: /run/user/1000/containers
  transientStore: false
  volumePath: /home/hank/.local/share/containers/storage/volumes
version:
  APIVersion: 4.4.1
  Built: 1675940333
  BuiltTime: Thu Feb  9 10:58:53 2023
  GitCommit: ""
  GoVersion: go1.19.5
  Os: linux
  OsArch: linux/amd64
  Version: 4.4.1



### Podman in a container

No

### Privileged Or Rootless

Rootless

### Upstream Latest Release

No

### Additional environment details

_No response_

### Additional information

_No response_
@hdonnay hdonnay added the kind/bug Categorizes issue or PR as related to a bug. label Apr 26, 2023
@github-actions github-actions bot added the remote Problem is in podman-remote label Apr 26, 2023
@flouthoc
Copy link
Collaborator

flouthoc commented Apr 27, 2023

Looks like this needs to be fixed at both podman and buildah end, if no destination is given use source as the destination and use docker:// as default transport.

@containers/podman-maintainers @mtrmac WDYT ?

See: https://docs.docker.com/engine/reference/commandline/manifest_push/

@Luap99
Copy link
Member

Luap99 commented Apr 27, 2023

Yes it should match the behaviour from podman-push IMO.

flouthoc added a commit to flouthoc/podman that referenced this issue May 1, 2023
`manifest push <source>` must work as-is if `source` is actually a valid
path and no destination is provided, `podman` must internally choose
`source` as its `destination` just like `podman push`

See: https://github.com/containers/podman/blob/main/cmd/podman/images/push.go#L161
Closes: containers#18360

Signed-off-by: Aditya R <arajan@redhat.com>
@flouthoc
Copy link
Collaborator

flouthoc commented May 1, 2023

PR #18395 should close this.

flouthoc added a commit to flouthoc/podman that referenced this issue May 1, 2023
`manifest push <source>` must work as-is if `source` is actually a valid
path and no destination is provided, `podman` must internally choose
`source` as its `destination` just like `podman push`

See: https://github.com/containers/podman/blob/main/cmd/podman/images/push.go#L161
Closes: containers#18360

Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc added a commit to flouthoc/podman that referenced this issue May 1, 2023
`manifest push <source>` must work as-is if `source` is actually a valid
path and no destination is provided, `podman` must internally choose
`source` as its `destination` just like `podman push`

See: https://github.com/containers/podman/blob/main/cmd/podman/images/push.go#L161
Closes: containers#18360

Signed-off-by: Aditya R <arajan@redhat.com>
lyarwood added a commit to lyarwood/kubevirt that referenced this issue May 23, 2023
publish-kubevirt-builder uses podman to build and publish the builder
image. This change works around a known podman manifest push bug [1] by
providing the destination until a now merged fix is released [2].

[1] containers/podman#18360
[2] containers/podman@bab4217

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
lyarwood added a commit to lyarwood/kubevirt that referenced this issue May 23, 2023
publish-kubevirt-builder uses podman to build and publish the builder
image. This change works around a known podman manifest push bug [1] by
providing the destination until a now merged fix is released [2].

[1] containers/podman#18360
[2] containers/podman@bab4217

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
lyarwood added a commit to lyarwood/kubevirt that referenced this issue May 23, 2023
publish-kubevirt-builder uses podman to build and publish the builder
image. This change works around a known podman manifest push bug [1] by
providing the destination until a now merged fix is released [2].

[1] containers/podman#18360
[2] containers/podman@bab4217

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants