Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment files with new line support #18724

Open
SiNONiMiTY opened this issue May 29, 2023 · 12 comments · Fixed by #19096
Open

Environment files with new line support #18724

SiNONiMiTY opened this issue May 29, 2023 · 12 comments · Fixed by #19096
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@SiNONiMiTY
Copy link

SiNONiMiTY commented May 29, 2023

Feature request description

Support loading of environment variable files with new line via --env-file, just like how DotEnv does it.

DotEnv Multiline Feature

Currently, loading environment files with values that span multiple lines don't work.
This is a very useful feature that I would like to be implemented.

@SiNONiMiTY SiNONiMiTY added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2023
@Luap99
Copy link
Member

Luap99 commented May 30, 2023

Adding support for this sounds good to me as long as it is backwards compatible with the existing parsing logic.

@hedayat
Copy link
Contributor

hedayat commented Jun 27, 2023

Is there any workarounds for this?

@Luap99
Copy link
Member

Luap99 commented Jun 28, 2023

pass the env on the cli with --env?

@hedayat
Copy link
Contributor

hedayat commented Jun 28, 2023

Not sure if it is practical enough for me. Actually I'm using podman-compose, and with multiple big env files, and it doesn't work currently because of this missing feature. Currently, I'm forced to go back to docker/docker-compose for this use case, which is not what I preferred.

@SiNONiMiTY
Copy link
Author

Not sure if it is practical enough for me. Actually I'm using podman-compose, and with multiple big env files, and it doesn't work currently because of this missing feature. Currently, I'm forced to go back to docker/docker-compose for this use case, which is not what I preferred.

Same here, I am more inclined to use the CLI rather than the podman/docker compose, and --env-file switch not parsing multiline environment variables is such a bummer.

@Luap99
Copy link
Member

Luap99 commented Jun 28, 2023

This is an open source project we always welcome PRs from the community.

BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 3, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 3, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 3, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 3, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 4, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 4, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 4, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 4, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 4, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 5, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 10, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 17, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 17, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 17, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 19, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

BlackHole1 added a commit to BlackHole1/podman that referenced this issue Jul 31, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
TomSweeneyRedHat pushed a commit to TomSweeneyRedHat/podman that referenced this issue Aug 9, 2023
Close: containers#18724

Signed-off-by: Black-Hole1 <bh@bugs.cc>
@Luap99
Copy link
Member

Luap99 commented Oct 6, 2023

The change got reverted as it broke backwards compat.

@Luap99 Luap99 reopened this Oct 6, 2023
@hedayat
Copy link
Contributor

hedayat commented Oct 6, 2023

Oops, now it breaks docker-compose compatibility... :(

@hedayat
Copy link
Contributor

hedayat commented Oct 10, 2023

If you want to keep backward compatibility to that extent, what about adding a new flag for using multi-line environment files?

@Luap99
Copy link
Member

Luap99 commented Oct 11, 2023

Note that the current behaviour is actually docker compatible. docker != docker-compose, docker run --env-file parses the file in the same format as we do. And you can just use docker-compose against the podman socket so there should not be an issue there as the file is always parsed on the client.
As for podman-compose you would need to ask there, podman-compose is not maintained by us.

Adding a new flag with a new format is certainly a possibility

@hedayat
Copy link
Contributor

hedayat commented Oct 11, 2023

Yeah, you are correct.

Adding a new flag with a new format is certainly a possibility

Can we proceed with this option instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants