Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose buildah --compression-level on push command #18939

Closed
ralbertazzi opened this issue Jun 20, 2023 · 1 comment · Fixed by #18940
Closed

Expose buildah --compression-level on push command #18939

ralbertazzi opened this issue Jun 20, 2023 · 1 comment · Fixed by #18940
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@ralbertazzi
Copy link

Feature request description

buildah push provides a --compression-level argument which is however not exposed on podman. It would be great to let this parameter bubble out in podman's CLI, similarly to --compression-format

Suggest potential solution

No response

Have you considered any alternatives?

The alternative would be to use buildah directly.

Additional context

No response
@ralbertazzi ralbertazzi added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2023
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
c7b0b00 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue Jun 20, 2023
Merged
@giuseppe
Copy link
Member

opened a PR to expose the option: #18940

giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
593feeb 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
c902371 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
5879342 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
e3685bc 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
9d68ccd 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
66ce890 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
5fff082 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 20, 2023
@giuseppe
cmd, push: expose --compression-level
92e4282 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 21, 2023
@giuseppe
cmd, push: expose --compression-level
d9ed414 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 21, 2023
@giuseppe
cmd, push: expose --compression-level
c07883b 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 21, 2023
@giuseppe
cmd, push: expose --compression-level
10a54ed 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Jun 21, 2023
@giuseppe
cmd, push: expose --compression-level
bb932cc 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgiradkar pushed a commit to cgiradkar/podman that referenced this issue Jul 12, 2023
@giuseppe @cgiradkar
cmd, push: expose --compression-level
6b7acaf 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgiradkar pushed a commit to cgiradkar/podman that referenced this issue Jul 13, 2023
@giuseppe @cgiradkar
cmd, push: expose --compression-level
2f0e95b 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgiradkar pushed a commit to cgiradkar/podman that referenced this issue Jul 17, 2023
@giuseppe @cgiradkar
cmd, push: expose --compression-level
8ac6fe3 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgiradkar pushed a commit to cgiradkar/podman that referenced this issue Jul 17, 2023
@giuseppe @cgiradkar
cmd, push: expose --compression-level
6043527 
This patch adds the --compression-level option to the push command.

Closes: containers#18939

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd, push: expose --compression-level giuseppe/libpod
2 participants
@giuseppe @ralbertazzi