Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for kube collections #19052

Closed
StanEgo opened this issue Jun 29, 2023 · 6 comments · Fixed by #19762
Closed

Support for kube collections #19052

StanEgo opened this issue Jun 29, 2023 · 6 comments · Fixed by #19762
Labels
kind/feature Categorizes issue or PR as related to a new feature. kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@StanEgo
Copy link

StanEgo commented Jun 29, 2023

Feature request description

It would be nice to have a support for https://kubernetes.io/docs/reference/using-api/api-concepts/#collections. Nothing sophisticated, just looks like a resource with "kind: List", but this greatly simplifies to play kube manifest in JSON with multiple resources. Right now code below results in "Error: playing YAML file: YAML document does not contain any supported kube kind" message:

{
  "apiVersion": "v1",
  "kind": "List",
  "items": [
    {
      "apiVersion": "v1",
      "kind": "ConfigMap",
      ...
    },
    {
      "apiVersion": "apps/v1",
      "kind": "Deployment",
      ...

Suggest potential solution

A clear and concise description of what you want to happen.

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@StanEgo StanEgo added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 29, 2023
@rhatdan rhatdan added the kube label Jun 29, 2023
@rhatdan
Copy link
Member

rhatdan commented Jun 29, 2023

@umohnani8 WDYT?

@christian-2
Copy link

@StanEgo You are aware that you can already place multiple resources in a single file with YAML's --- marker, right? (Does not help directly with JSON, though.)

@StanEgo
Copy link
Author

StanEgo commented Jul 24, 2023

@StanEgo You are aware that you can already place multiple resources in a single file with YAML's --- marker, right? (Does not help directly with JSON, though.)

Yes. this is specifically JSON case.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Aug 25, 2023

@ygalblum WDYT?

@ygalblum
Copy link
Collaborator

I don't see a reason why not to support this. Especially since the code already handles a list of documents. It will just need to be adjusted to a document that is a list.
I'll see if I can find a time slot for this

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants