Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube - support List documents #19762

Merged
merged 1 commit into from Aug 28, 2023
Merged

Kube - support List documents #19762

merged 1 commit into from Aug 28, 2023

Conversation

ygalblum
Copy link
Collaborator

Flatten List into documents
Add List type to meta/v1
Add unittest

Does this PR introduce a user-facing change?

Yes

Kube - add support for List kind

Resolves: #19052

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2023
giuseppe
giuseppe approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack understanding on how we want this to behave on the command level. Running the example YAML for the unit test gives me Error: pod does not have a name. Can we add an e2e test?

pkg/domain/infra/abi/play.go Show resolved Hide resolved
@ygalblum
Copy link
Collaborator Author

Running the example YAML for the unit test gives me Error: pod does not have a name.

The unit test does not check the content of the items just that the items were separated into different documents. The content mimics the other cases in the same unit test (which does not include a name either).

Can we add an e2e test?

Will do

@ygalblum
Copy link
Collaborator Author

Will do

Done

vrothberg
vrothberg approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,vrothberg,ygalblum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ygalblum
Kube - support List documents
7ef97fa 
Flatten List into documents
Add List type to meta/v1
Add unittest
Add e2e test

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
@mheon
Copy link
Member

mheon commented Aug 28, 2023

The test failures look like network flakes. Will rerun.
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@baude
Copy link
Member

baude commented Aug 28, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit ef4ca8b into containers:main Aug 28, 2023
93 checks passed
@ygalblum ygalblum deleted the kube-support-list branch August 29, 2023 06:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@vrothberg vrothberg vrothberg approved these changes

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for kube collections
6 participants
@ygalblum @mheon @baude @giuseppe @vrothberg @openshift-merge-robot