You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
make lint or winmake lint are both failing on windows currently so contributors don't know how to run the linter against the local changes before pushing a commit.
Suggest potential solution
It's possible to install golangci-lint on Windows (winget add -e GolangCI.golangci-lint ) but running it complains because diff is not found. To get diff we can then include Git for windows bin folder to PATH ($Env:Path += ";C:\Program Files\Git\usr\bin") but then some new errors are thrown...it will eventually work but it needs some more time.
Have you considered any alternatives?
We could provide instructions (or a new make target) to execute make lint in a container using podman run.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Add the following targets in winmake.ps1:
- `installer`: builds the Windows installer
- `docs`: builds the documentation HTML pages
- `validatepr`: runs the Linux Makefile `.valiatepr`
target using podman.
- `lint`: faster validation that runs linter locally
Update of `build_windows.md`:
- removed every reference to the MSYS2 platform
- added instructions to build the installer and linters
Fixcontainers#21821 and containers#21911
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Add the following targets in winmake.ps1:
- `installer`: builds the Windows installer
- `docs`: builds the documentation HTML pages
- `validatepr`: runs the Linux Makefile `.valiatepr`
target using podman.
- `lint`: faster validation that runs linter locally
Update of `build_windows.md`:
- removed every reference to the MSYS2 platform
- added instructions to build the installer and linters
Fixcontainers#21821 and containers#21911
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Feature request description
make lint
orwinmake lint
are both failing on windows currently so contributors don't know how to run the linter against the local changes before pushing a commit.Suggest potential solution
It's possible to install golangci-lint on Windows (
winget add -e GolangCI.golangci-lint
) but running it complains becausediff
is not found. To getdiff
we can then include Git for windows bin folder toPATH
($Env:Path += ";C:\Program Files\Git\usr\bin"
) but then some new errors are thrown...it will eventually work but it needs some more time.Have you considered any alternatives?
We could provide instructions (or a new make target) to execute
make lint
in a container usingpodman run
.Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: