Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include arch/os in image libpod list #22185

Closed
benoitf opened this issue Mar 27, 2024 · 3 comments · Fixed by #22266
Closed

include arch/os in image libpod list #22185

benoitf opened this issue Mar 27, 2024 · 3 comments · Fixed by #22266
Assignees
Labels
jira kind/feature Categorizes issue or PR as related to a new feature. podman-desktop

Comments

@benoitf
Copy link
Contributor

benoitf commented Mar 27, 2024

Feature request description

Today,

 "Architecture": "arm64",
"Os": "linux",

are only available when we inspect an image

But usually this information is useful when we want to list images. For example to know if an image is using amd64 or Apple Silicon computer, etc.

so it requires one additional query for each image.

Suggest potential solution

Include

 "Architecture": "arm64",
"Os": "linux",

as part of libpod/images/json return this information

could be with an additional query parameter to the endpoint ?arch=true&os=true, ?displayArchAndOs, whatever so opt-in query.

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@benoitf benoitf added kind/feature Categorizes issue or PR as related to a new feature. podman-desktop labels Mar 27, 2024
@rhatdan
Copy link
Member

rhatdan commented Apr 1, 2024

@vrothberg PTAL, I think the problem here is that libimage does not return these by default but only in inspectinfo. Valentin would their be a penalty to return these automatically in list?

@vrothberg
Copy link
Member

@vrothberg PTAL, I think the problem here is that libimage does not return these by default but only in inspectinfo.

libimage returns libimage.Image objects that can be queried for this information.

Valentin would their be a penalty to return these automatically in list?

Yes, this information comes at some cost. In theory, Podman Desktop could get this information in two steps:

  1. List all images.
  2. Inspect each image for the OS/Arch information.

It could certainly be made part of images/json; maybe via an opt-in parameter.

PS: I have no time to implement this feature at the moment.

@baude
Copy link
Member

baude commented Apr 2, 2024

i have the ball on this one.

@baude baude self-assigned this Apr 2, 2024
@mheon mheon added the jira label Apr 2, 2024
baude added a commit to baude/podman that referenced this issue Apr 3, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Apr 3, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Apr 4, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Apr 4, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Apr 4, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Apr 5, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Apr 5, 2024
when listing images through the restful service, consumers want to know
if the image they are listing is a manifest or not because the libpod
endpoint returns both images and manifest lists.

in addition, we now add `arch` and `os` as fields in the libpod endpoint
for image listing as well.

Fixes: containers#22184
Fixes: containers#22185

Signed-off-by: Brent Baude <bbaude@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira kind/feature Categorizes issue or PR as related to a new feature. podman-desktop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants