Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: point to slirp4netns #2506

Closed
tobwen opened this issue Mar 3, 2019 · 4 comments
Closed

podman: point to slirp4netns #2506

tobwen opened this issue Mar 3, 2019 · 4 comments
Assignees
@giuseppe
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. rootless

Comments

@tobwen
Copy link
Contributor

tobwen commented Mar 3, 2019

/kind feature

Description
It should be possible to point to the binary of slirp4netns in commandline parameter and in config.

Right now, it seems to look in $PATH only: #1234
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 3, 2019
@mheon mheon added the rootless label Mar 4, 2019
@tobwen
Copy link
Contributor Author

tobwen commented Mar 4, 2019

Can I bump this? It's pretty important, since there's no other way than to hack with PATH variables right now :-(

@rhatdan
Copy link
Member

rhatdan commented Mar 4, 2019

Open a PR to make a change.

@tobwen
Copy link
Contributor Author

tobwen commented Mar 4, 2019

@rhatdan I'd love to, but I'm not a go coder. Maybe I can hack it from existing code. Let me try.

giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 5, 2019
@giuseppe
libpod: allow to configure path to the slirp4netns binary
3e32b3a 
allow to configure the path to the slirp4netns binary, either via an
option flag --slirp4netns or through the libpod.conf configuration
file.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue Mar 5, 2019
Merged
@giuseppe
Copy link
Member

giuseppe commented Mar 5, 2019

PR here: #2538

giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 5, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
07f9d76 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 5, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
cc3f82b 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 5, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
081318e 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 8, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
603b093 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 8, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
4204434 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 9, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
6824329 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this issue Mar 11, 2019
@giuseppe
libpod: allow to configure path to the network-cmd binary
e02393b 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
muayyad-alsadi pushed a commit to muayyad-alsadi/libpod that referenced this issue Apr 21, 2019
@giuseppe @muayyad-alsadi
libpod: allow to configure path to the network-cmd binary
63ebcbf 
allow to configure the path to the network-cmd binary, either via an
option flag --network-cmd-path or through the libpod.conf
configuration file.

This is currently used to customize the path to the slirp4netns
binary.

Closes: containers#2506

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@giuseppe giuseppe

Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. rootless
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@giuseppe @tobwen @rhatdan @mheon @openshift-ci-robot