'volume rm' requires complete volume name instead of unambiguous volume name

[undecaf]

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

podman volume rm requires the complete volume name whereas containers can be identified by an unambiguous abbreviation of their name.

Steps to reproduce the issue:

1. podman volume create a
podman volume create insanelylonghashstring

2. # i unambiguously identifies insanelylonghashstring
podman volume rm i

Describe the results you received:
Error: volume with name i not found: no such volume, volume still existing

Describe the results you expected:
insanelylonghashstring, volume removed

Additional information you deem important (e.g. issue happens only occasionally):
May be related to #3635.

Output of podman version:

Version:            1.5.0
RemoteAPI Version:  1
Go Version:         go1.10.4
OS/Arch:            linux/amd64

Output of podman info --debug:

debug:
  compiler: gc
  git commit: ""
  go version: go1.10.4
  podman version: 1.5.0
host:
  BuildahVersion: 1.10.1
  Conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.0, commit: unknown'
  Distribution:
    distribution: ubuntu
    version: "18.04"
  MemFree: 43922792448
  MemTotal: 50628587520
  OCIRuntime:
    package: 'containerd.io: /usr/sbin/runc'
    path: /usr/sbin/runc
    version: |-
      runc version 1.0.0-rc6+dev
      commit: 2b18fe1d885ee5083ef9f0838fee39b62d653e30
      spec: 1.0.1-dev
  SwapFree: 0
  SwapTotal: 0
  arch: amd64
  cpus: 16
  eventlogger: journald
  hostname: poseidon
  kernel: 5.0.0-25-generic
  os: linux
  rootless: true
  uptime: 6h 57m 40.34s (Approximately 0.25 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /home/kasper/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: vfs
  GraphOptions: null
  GraphRoot: /home/kasper/.local/share/containers/storage
  GraphStatus: {}
  ImageStore:
    number: 20
  RunRoot: /tmp/1000
  VolumePath: /home/kasper/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):

podman/bionic,now 1.5.0-2~ubuntu18.04~ppa5 amd64  [installiert]

Additional environment details (AWS, VirtualBox, physical, etc.):

$ uname -a
Linux poseidon 5.0.0-25-generic #26~18.04.1-Ubuntu SMP Thu Aug 1 13:51:02 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

$ cat /etc/*-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.3 LTS"
NAME="Ubuntu"
VERSION="18.04.3 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.3 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

[mheon]

I think we went a bit too far when fixing #3635 then.

I'll take this one.

[mheon]

Hm. I'm actually not sure this is intended to work.

Docker requires a full volume name to remove a volume; docker create abcd; docker rm a on an empty state (so no conflicting names) errors that there is no volume with the name a.

We could consider adding this, but I'm retagging as a feature request, not a bug, given this doesn't appear to be Docker behavior.

[mheon]

I think we want to allow these lookup operations only for volume commands - rm, inspect.

Adding volumes to containers with -v and --mount will continue to require exact name matching.

[undecaf]

@mheon I am sorry that I did not take a look at Docker first.
Nevertheless, being able to abbreviate volume names in certain situations would be a nice time-saver.

[rhatdan]

Well @undecaf Looks like @mheon is taking a stab at supporting shorter names, Please try it out and see if it satisfies your needs.

[undecaf]

@rhatdan @mheon Thanks! And will do ...