Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6 rc2, fc30, rootless: warnings about missing crun #4115

Closed
edsantiago opened this issue Sep 26, 2019 · 8 comments · Fixed by #4124
Closed

1.6 rc2, fc30, rootless: warnings about missing crun #4115

edsantiago opened this issue Sep 26, 2019 · 8 comments · Fixed by #4124
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Collaborator

(Similar to, but not the same as, #4012)

podman-1.6.0-0.2.rc2.fc30 rootless outputs copious warnings by default:

$ podman images
WARN[0000] Error initializing configured OCI runtime crun: no valid executable found for OCI runtime crun: invalid argument
WARN[0000] Error initializing configured OCI runtime crun: no valid executable found for OCI runtime crun: invalid argument
REPOSITORY                   TAG       IMAGE ID       CREATED        SIZE
....

This is fc30, not fc31. I made the warnings go away by hand-editing ~/.config/containers/libpod.conf but am concerned that this is going to come back and haunt us; in particular, regular users will end up doing the same (removing runc from config) and then ending up with nonworking podman when they upgrade to fc31.

@mheon
Copy link
Member

mheon commented Sep 26, 2019

This repros as rootless, but not as root. I'm really confused as to why default log level is not the same between the two.

@mheon
Copy link
Member

mheon commented Sep 26, 2019

We explicitly set ERROR level logging by default for Podman, unconditionally, unless overridden by CLI.

@mheon
Copy link
Member

mheon commented Sep 26, 2019

$ podman info --log-level=error
WARN[0000] cannot find mappings for user mcs: No subuid ranges found for user "mcs" in /etc/subuid 
WARN[0000] using rootless single mapping into the namespace. This might break some images. Check /etc/subuid and /etc/subgid for adding subids 

Well there's our problem. logrus as rootless is ignoring log-level=error. Maybe something about how we exec a new process?

@mheon
Copy link
Member

mheon commented Sep 26, 2019

I think it's definitely the re-exec part of rootless.

@edsantiago
Copy link
Collaborator Author

Nice. Fixing this bug may then fix #4012 and get gating tests to pass on rawhide.

@mheon
Copy link
Member

mheon commented Sep 26, 2019

@giuseppe Poke - where does rootless re-exec happen? I'm trying to trace the code, but getting lost in the make pause process vs join pause process bit.

@mheon
Copy link
Member

mheon commented Sep 26, 2019

Alright, we seem to be passing literal argv into the reexec'd process... So I don't see how we're losing the log level.

@mheon
Copy link
Member

mheon commented Sep 26, 2019

Does not seem directly related to reexec... I can get it to happen both inside and outside the rootless user namespace.

mheon added a commit to mheon/libpod that referenced this issue Sep 26, 2019
If we don't do this, we print WARN level messages that we should
not be printing by default.

Up one WARN message to ERROR so it still shows up by default.

Fixes: containers#4115
Fixes: containers#4012

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants