Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate systemd: add network dependency #4130

Closed
vrothberg opened this issue Sep 27, 2019 · 5 comments · Fixed by #5382
Closed

generate systemd: add network dependency #4130

vrothberg opened this issue Sep 27, 2019 · 5 comments · Fixed by #5382
Assignees
@vrothberg
Labels
do-not-close locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@vrothberg
Copy link
Member

To support enabling services at system startup, the generated services need to add networking dependencies, namely:

Wants=network.target
After=network-online.target

Can be tested with enabling a generated service and testing the network connection of the container after reboot. Should also make sure that exposed ports are reachable.
@github-actions
Copy link

This issue had no activity for 30 days. In the absence of activity or the "do-not-close" label, the issue will be automatically closed within 7 days.

@mheon
Copy link
Member

mheon commented Oct 30, 2019

@vrothberg @baude We may want to exclude anything with a kind/feature label from this reaping. I don't think closing feature requests because nobody has had a chance to work on them is productive.

@vrothberg
Copy link
Member Author

@mheon, I think the bot only supports one exempt label. I think it doesn't hurt to be reminded of inactivity - adding the "do-not-close" label will prevent it from being closed in the future.

@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2020

@vrothberg Did you ever get around to this? Shouldn't this be a simple fix?

@vrothberg
Copy link
Member Author

Didn't do it yet. I planned to tackle it when working on a bigger item for systemd generation.

vrothberg added a commit to vrothberg/libpod that referenced this issue Mar 3, 2020
@vrothberg
generate systemd: add network dependencies
05a0bf7 
Add network dependencies to generated systemd services to allow for
enabling them at system startup and have a working network if needed.

Fixes: containers#4130
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg vrothberg mentioned this issue Mar 3, 2020
Merged
edsantiago pushed a commit to edsantiago/libpod that referenced this issue Mar 5, 2020
@vrothberg @edsantiago
generate systemd: add network dependencies
0609f47 
Add network dependencies to generated systemd services to allow for
enabling them at system startup and have a working network if needed.

Fixes: containers#4130
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
snj33v pushed a commit to snj33v/libpod that referenced this issue May 31, 2020
@vrothberg @snj33v
generate systemd: add network dependencies
e247997 
Add network dependencies to generated systemd services to allow for
enabling them at system startup and have a working network if needed.

Fixes: containers#4130
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
do-not-close locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

generate systemd: add network dependencies vrothberg/libpod
3 participants
@rhatdan @mheon @vrothberg