Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-remote: podman push - invalid memory address or nil pointer dereference #4706

Closed
bszeti opened this issue Dec 16, 2019 · 2 comments · Fixed by #4985
Closed

podman-remote: podman push - invalid memory address or nil pointer dereference #4706

bszeti opened this issue Dec 16, 2019 · 2 comments · Fixed by #4985
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@bszeti
Copy link

bszeti commented Dec 16, 2019

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Using podman-remote on MacOS with a remote Fedora 31. Command 'podman push' drops a go error:

$ podman push 56d835d0d82f docker://quay.io/bszeti/podmantest:latest
panic: runtime error: invalid memory address or nil pointer dereference

Steps to reproduce the issue:

  1. Pull or build and image (in my case image Id: 56d835d0d82f)
  2. Try to push the image to a remote registry using podman-remote
    podman push 56d835d0d82f docker://quay.io/bszeti/podmantest:latest

Describe the results you received:
Command drops error.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x1ec883c]

goroutine 1 [running]:
main.pushCmd(0x33552e0, 0x0, 0x0)
	cmd/podman/push.go:97 +0x29c
main.glob..func57(0x332fb40, 0xc000393b80, 0x2, 0x2, 0x0, 0x0)
	cmd/podman/push.go:36 +0x94
github.com/spf13/cobra.(*Command).execute(0x332fb40, 0xc0000bc020, 0x2, 0x2, 0x332fb40, 0xc0000bc020)
	vendor/github.com/spf13/cobra/command.go:826 +0x465
github.com/spf13/cobra.(*Command).ExecuteC(0x3331440, 0x6, 0xc000044047, 0x31)
	vendor/github.com/spf13/cobra/command.go:914 +0x2fc
github.com/spf13/cobra.(*Command).Execute(...)
	vendor/github.com/spf13/cobra/command.go:864
main.main()
	cmd/podman/main.go:160 +0xb0

Describe the results you expected:
Successful push.

Additional information you deem important (e.g. issue happens only occasionally):
Same command works without issue if it's executed on the Linux host.

Output of podman version:

Client:
Version:            1.6.1-dev
RemoteAPI Version:  1
Go Version:         go1.12.9
OS/Arch:            darwin/amd64

Service:
Version:            1.6.2
RemoteAPI Version:  1
Go Version:         go1.13.1
OS/Arch:            linux/amd64

Output of podman info --debug:

client:
  Connection: unix:/run/podman/io.podman
  Connection Type: DirectConnection
  OS Arch: darwin/amd64
  Podman Version: 1.6.1-dev
  RemoteAPI Version: 1
host:
  arch: amd64
  buildah_version: 1.11.3
  cpus: 1
  distribution:
    distribution: fedora
    version: "31"
  eventlogger: journald
  hostname: localhost.localdomain
  kernel: 5.3.15-300.fc31.x86_64
  mem_free: 409231360
  mem_total: 2084048896
  os: linux
  swap_free: 2112167936
  swap_total: 2147479552
  uptime: 2h 45m 59.63s (Approximately 0.08 days)
insecure registries:
  registries: null
registries:
  registries: null
store:
  containers: 7
  graph_driver_name: overlay
  graph_driver_options: map[overlay.mountopt:nodev,metacopy=on]
  graph_root: /var/lib/containers/storage
  graph_status:
    backing_filesystem: extfs
    native_overlay_diff: "false"
    supports_d_type: "true"
  images: 21
  run_root: /var/run/containers/storage

Package info (e.g. output of rpm -q podman or apt list podman):

MacOS: podman-v1.6.0-28-gdac7889d
Linux host: podman-1.6.2-2.fc31.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
MacOS: 10.15.2
Remote linux: Fedora 31

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 16, 2019
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jan 16, 2020

I believe this is still an issue.

baude added a commit to baude/podman that referenced this issue Jan 26, 2020
The pull command has several options that are hidden for the remote client.  In that case, when checking to see if the flag has been flipped with .Changed, we get a nil pointer error.  Using IsSet is tolerant of this.

Fixes: containers#4706

Signed-off-by: Brent Baude <bbaude@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants