Fix image prune --filter cmd behavior #10390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jmguzik
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rhatdan
reviewed
May 19, 2021
|
/approve |
openshift-ci
bot
added
the
approved
|
@jmguzik Still working ont his? |
Yes, but not enough time this week. |
vrothberg
reviewed
Jun 3, 2021
There is no particular issue. I just found the error, not reported it as an issue, instead opened a PR. |
jmguzik
force-pushed
the
fix-cmd-prune-filter-images
branch
from
c74d3a7
to
6e9528c
Compare
The challenge I have as a reader/reviewer of the commit message is that it mentions to fix something but it doesn't state what the problem actually was. |
jmguzik
force-pushed
the
fix-cmd-prune-filter-images
branch
from
6e9528c
to
e909a69
Compare
Added commit description with further info about the problem. |
Image prune --filter is fully implemented in the api, http api yet not connected with the cli execution. User trying to use filters does not see the effect. This commit adds glue code to enable possiblity of using --filter in prune in the cli execution. Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
jmguzik
force-pushed
the
fix-cmd-prune-filter-images
branch
from
e909a69
to
a5ad36c
Compare
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openstack-mirroring
pushed a commit
to openstack-archive/tripleo-heat-templates
that referenced
this pull request
Feb 3, 2022
With the undercloud using ephemeral Heat, there will be images for ephemeral Heat in the local container storage that do not have any associated containers. Podman purge would delete these images, and they then wouldn't be available for overcloud commands. Instead, skip running the podman purge tasks on the Undercloud. This means that the local container image storage will grow over time. Given the reduced number of services on the undercloud, the storage usage is not as bad as it was previously. However, operators will need to be aware. While "podman image prune" does have a --filter option to preserve images, it does not work in the version of podman in container-tools:3.0. When the needed patch[1] is available, the podman purge tasks can be re-enabled, which would address the issue of growing local storage. [1] containers/podman@a5ad36c [2] containers/podman#10390 Change-Id: Ibd2200aa912960b267a9975571e05665a29e40f0 Signed-off-by: James Slagle <jslagle@redhat.com>
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 3, 2022
* Update tripleo-heat-templates from branch 'master'
to c4aa1e3464c6a332edcf1a1abe08047f0350efa6
- Merge "Skip podman purge on Undercloud"
- Skip podman purge on Undercloud
With the undercloud using ephemeral Heat, there will be images for
ephemeral Heat in the local container storage that do not have any
associated containers. Podman purge would delete these images, and they
then wouldn't be available for overcloud commands.
Instead, skip running the podman purge tasks on the Undercloud. This
means that the local container image storage will grow over time. Given
the reduced number of services on the undercloud, the storage usage is
not as bad as it was previously. However, operators will need to be
aware.
While "podman image prune" does have a --filter option to preserve
images, it does not work in the version of podman in
container-tools:3.0. When the needed patch[1] is available, the podman
purge tasks can be re-enabled, which would address the issue of growing
local storage.
[1] containers/podman@a5ad36c
[2] containers/podman#10390
Change-Id: Ibd2200aa912960b267a9975571e05665a29e40f0
Signed-off-by: James Slagle <jslagle@redhat.com>
openstack-mirroring
pushed a commit
to openstack-archive/tripleo-heat-templates
that referenced
this pull request
Feb 17, 2022
With the undercloud using ephemeral Heat, there will be images for ephemeral Heat in the local container storage that do not have any associated containers. Podman purge would delete these images, and they then wouldn't be available for overcloud commands. Instead, skip running the podman purge tasks on the Undercloud. This means that the local container image storage will grow over time. Given the reduced number of services on the undercloud, the storage usage is not as bad as it was previously. However, operators will need to be aware. While "podman image prune" does have a --filter option to preserve images, it does not work in the version of podman in container-tools:3.0. When the needed patch[1] is available, the podman purge tasks can be re-enabled, which would address the issue of growing local storage. [1] containers/podman@a5ad36c [2] containers/podman#10390 Change-Id: Ibd2200aa912960b267a9975571e05665a29e40f0 Signed-off-by: James Slagle <jslagle@redhat.com> (cherry picked from commit 7eb280a)
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glue code added to push filters to the prune image engine method.