New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to string for dockerfile parameter #10661
Conversation
Can you added a test for this? |
Doesn't look like you can post a file with the apiv2 stuff? I'm looking into it today |
Ahhh. Yeah, the APIv2 tests might be too limited for this. |
I made it work with apiv2 tests. It's probably easier than trying to implemented it in the python tests but i can move it over there if needed |
a9cb824 changed the expectations of the dockerfile parameter to be json data however it's a string. In order to support both, let's attempt json and fall back to a string if the json parsing fails. Closes containers#10660 Signed-off-by: Alex Schultz <aschultz@redhat.com>
Awesome work @mwhahaha LGTM |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwhahaha, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
a9cb824 changed the expectations of the
dockerfile parameter to be json data however it's a string. In order to
support both, let's attempt json and fall back to a string if the json
parsing fails.
Closes #10660
Signed-off-by: Alex Schultz aschultz@redhat.com