Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3.2.3-rhel] play kube: support capitalized pull policy #11045

Closed
wants to merge 1 commit into from
Closed

[v3.2.3-rhel] play kube: support capitalized pull policy #11045

wants to merge 1 commit into from

Conversation

vrothberg
Copy link
Member

Pull policies in K8s yaml may be capitalized, so lower them before
parsing.

Fixes: bugzilla.redhat.com/show_bug.cgi?id=1985905
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@vrothberg
play kube: support capitalized pull policy
cb85964 
Pull policies in K8s yaml may be capitalized, so lower them before
parsing.

Fixes: bugzilla.redhat.com/show_bug.cgi?id=1985905
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@vrothberg
Copy link
Member Author

/hold
Need to wait for an ACK in the BZ before we can merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2021
@vrothberg
Copy link
Member Author

@TomSweeneyRedHat @rhatdan PTAL

Have a qa ack on it.

@cdoern
Copy link
Collaborator

cdoern commented Jul 28, 2021

LGTM, but is a fully capitalized or camel capitalized pull allowed because this will read that as valid as well.

@vrothberg
Copy link
Member Author

LGTM, but is a fully capitalized or camel capitalized pull allowed because this will read that as valid as well.

Probably only the camel case (see https://docs.openshift.com/container-platform/4.1/openshift_images/managing_images/image-pull-policy.html). Very good catch, @cdoern!

@vrothberg
Copy link
Member Author

Looks like we moved it over to be fixed with 3.3, so I can close here. Will massage libimage parsing a bit to accept the camel cases

@vrothberg vrothberg closed this Jul 29, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrothberg @cdoern