e2e test cleanup: check exit statuses #11597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e Cleanup handlers run various 'rm' commands, but don't check the exit status of any. This masks real problems such as the unlinkat-EBUSY flake (containers#11594) which only triggers on container/pod rm. Solution: check exit status: a failure in cleanup will now be considered a failure in the test itself. Signed-off-by: Ed Santiago <santiago@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
That's the point. The flakes are happening, we're just not seeing them. I'd rather see them here than downstream. |
|
Oh well. It was worth a shot. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e Cleanup handlers run various 'rm' commands, but don't
check the exit status of any. This masks real problems such
as the unlinkat-EBUSY flake (#11594) which only triggers on
container/pod rm.
Solution: check exit status: a failure in cleanup will now be
considered a failure in the test itself.
Signed-off-by: Ed Santiago santiago@redhat.com