Allow label and labels when creating volumes #12133
Conversation
JSON payload may have either key. Labels will override any values set via Label. Fixes containers#12102 Signed-off-by: Jhon Honce <jhonce@redhat.com>
jwhonce
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
LGTM
Side note: it seems like jsoniter supports multiple tags for one field (see https://stackoverflow.com/questions/38809137/golang-multiple-json-tag-names-for-one-field).
|
/lgtm |
|
@vrothberg I choose to not utilize that feature as the server uses |
|
@jwhonce TYVM for the libpod fix for this issue! |
| if len(input.Label) > 0 { | ||
| volumeOptions = append(volumeOptions, libpod.WithVolumeLabels(input.Label)) | ||
|
|
||
| // Label provided for compatibility. |
There was a problem hiding this comment.
Can we possibly error if the user provides both? If we allow both to be specified we get into weird edge-cases where both specify different values for the same label.
github-actions
bot
added
the
locked - please file new issue/PR
JSON payload may have either key. Labels will override any values set
via Label.
re: containers/podman-py#140
Fixes #12102
Signed-off-by: Jhon Honce jhonce@redhat.com
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: