Create pod CGroups with the systemd driver #1266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First new PR since papr was fixed, let's see if it works here |
|
Alright, so the bot is working, but PRs are still not being tested without Homu. |
|
bot, retest this please |
2 similar comments
|
bot, retest this please |
|
bot, retest this please |
mheon
force-pushed
the
systemd_cgroup_create
branch
3 times, most recently
from
1adca70
to
afc0893
Compare
|
I can't replicate this travis failure at all locally. It looks like it should be succeeding - the devmapper and btrfs packages it complained about are present. |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
mheon
force-pushed
the
systemd_cgroup_create
branch
2 times, most recently
from
721247c
to
53f5b04
Compare
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
mheon
force-pushed
the
systemd_cgroup_create
branch
from
869cc40
to
804e830
Compare
|
bot, retest this please |
1 similar comment
|
bot, retest this please |
|
@baude We fixed travis and now Papr is flaking. Just can't win. |
|
I always win |
|
LGTM |
|
LGTM |
|
LGTM |
|
📌 Commit 804e830 has been approved by |
|
⚡ Test exempted: merge already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 15, 2018
Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #1266 Approved by: baude
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 15, 2018
Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #1266 Approved by: baude
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 15, 2018
Signed-off-by: Matthew Heon <matthew.heon@gmail.com> Closes: #1266 Approved by: baude
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the name says. Expand pod support so we now create per-pod CGroups when managed by systemd.
Also change the default parent to machine.slice (more correct than system.slice - it's where containers are supposed to go)