Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container,inspect: convert Entrypoint to an array instead of a string #13811

Merged

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Apr 8, 2022

Convert container entrypoint from string to an array inorder to make
sure there is parity between podman inspect <ctr> and docker inspect <ctr>

Closes: #13803

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's a breaking change but Docker-compat turns it into a fix :^)

@rhatdan
Copy link
Member

rhatdan commented Apr 8, 2022

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Convert container entrypoint from string to an array inorder to make
sure there is parity between `podman inspect` and `docker inspect`

Signed-off-by: Aditya R <arajan@redhat.com>
@flouthoc flouthoc force-pushed the container_inspect_entrypoint branch from e94a347 to 0cebd15 Compare April 8, 2022 13:14
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@rhatdan
Copy link
Member

rhatdan commented Apr 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 8, 2022

@containers/podman-maintainers PTAL

@jwhonce
Copy link
Member

jwhonce commented Apr 8, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 343778f into containers:main Apr 8, 2022
@Luap99
Copy link
Member

Luap99 commented Apr 21, 2022

I just noticed that this breaks our own libpod api while running @baude new machine test. The inspect struct is send over the wire, should we revert this?!

@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 21, 2022

@Luap99 I'm okay if we revert this but shouldn't we fix the test then as this is needed for docker compatibility ? anyways I don't have a strict opinion on this so If this is blocker then no issues in reverting this but we might need this at some point and we will have to fix the tests then.

@Luap99
Copy link
Member

Luap99 commented Apr 21, 2022

docker compat vs podman comapt? At some point we should accept that there are also podman users who use this.
This breaks every 4.0 vs 4.1 compat via the remote api
Error: json: cannot unmarshal string into Go struct field InspectContainerConfig.Config.Entrypoint of type []string and this failed on a podman-remote run for some reason so this is very bad.

If we take semver seriously we cannot change this until 5.0

@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 21, 2022

@Luap99 I think we should get this in 5.0 it would be better there if this breaking remote 4.0 vs 4.1 api as of now.

@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2022

The question is what is more important Docker Compatibility or Podman compatibility.

@flouthoc
Copy link
Collaborator Author

@rhatdan I'm not sure what would be a priority here but it looks like this is breaking exisiting compat api users who are using 4.0 client against 4.1 server. Is that right @Luap99 ?

@flouthoc
Copy link
Collaborator Author

@rhatdan @Luap99 a PR here is we decide to revert this #13963

@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2022

Can we do the newer change in just Docker API?

@flouthoc
Copy link
Collaborator Author

@rhatdan Original issue requested a fix on podman side so only fixing it for docker API might not be enough so I guess it should be good for 5.0.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entrypoint should be an array in output of podman inspect
6 participants