Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] pkg/bindings: document requirements for use #13826

Merged

Conversation

stevekuznetsov
Copy link
Contributor

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

This is necessary until #6866 is (really) fixed.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@mheon
Copy link
Member

mheon commented Apr 11, 2022

Reposting from IRC:

Standard build tags for remote Podman, which should be identical to what an app built on the bindings should require:
remote exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper containers_image_openpgp

Of these the remote tag can probably be discarded, as it specifically instructs Podman to build without local-only CLI bits - but at the same time, it shouldn't hurt to keep it.

@mheon
Copy link
Member

mheon commented Apr 11, 2022

I think those should prevent most of the build/run dependencies from being required, but will have to verify locally.

@stevekuznetsov
Copy link
Contributor Author

@mheon let me know when you've had a moment to check, and I will update this README to say - either install the deps, or use these tags (do you set them for your downstream repo's go build ...?)

@baude
Copy link
Member

baude commented Apr 11, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 81b9646 into containers:main Apr 11, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants