Translate Memory Limit to Swap in API #13839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttys3 PTAL |
|
@jwhonce am I passing the limits incorrectly here? this works when I directly access the API via my command line but memory seems to be |
rhatdan
changed the title
|
@cdoern please fix your commit message on your next push. Tanslate -> Translate. |
cdoern
force-pushed
the
swap
branch
2 times, most recently
from
c65151d
to
fd34b90
Compare
in specgen, CLI path uses the given memory limit to define the swap value (if not already specified) add a route to this piece of code from within the api handlers resolves containers#13145 Signed-off-by: cdoern <cdoern@redhat.com>
|
rebased as the only test failure was some repetitive flake. @containers/podman-maintainers PTAL |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In specgen, the CLI creation route uses the given memory limit to define the swap value (if not already specified). added a route to this piece of code from within the api handlers
resolves #13145
Signed-off-by: cdoern cbdoer23@g.holycross.edu