[v3.2.3-rhel] backport libpod: refine check for empty pod cgroup #13879
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Does not build correctly. |
|
@rhatdan it is building fine for me on my machine. What error are you seeing? |
|
Builds fine for me on local, looks like CI is using very old GCP image. This could be an issue with the CI itself. |
|
@cevich any idea how we can update the image being used by CI here |
|
Rebase after #13915 merges |
|
Once merged, please set the associated BZ to "POST" |
rootless containers do not use cgroups on cgroupv1 or if using cgroupfs, so improve the check to account for such configuration. Closes: containers#10800 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2028243 [NO NEW TESTS NEEDED] it requires rebooting and the rundir on a non tmpfs file system. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
Tests are green! Can I please get a lgtm here @TomSweeneyRedHat @rhatdan @mheon |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Backport of #12828
Helps fix https://bugzilla.redhat.com/show_bug.cgi?id=2028243
rootless containers do not use cgroups on cgroupv1 or if using
cgroupfs, so improve the check to account for such configuration.
Closes: #10800
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2028243
[NO NEW TESTS NEEDED] it requires rebooting and the rundir on a non
tmpfs file system.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
Signed-off-by: Urvashi Mohnani umohnani@redhat.com