Cirrus: Simplify only_if/skip + optimize multiarch #14438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Examples of tasks created (ignore failed status):
|
cevich
changed the title
cevich
changed the title
cevich
force-pushed
the
replace_skips
branch
3 times, most recently
from
2b7a1a7
to
5091eeb
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
cevich
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Re-WIPing this, found a problem that needs fixing. |
cevich
force-pushed
the
replace_skips
branch
2 times, most recently
from
26c34e1
to
82da89c
Compare
|
Force-push: Rebased, added exclusion of all integration-level tasks running on branches where they're less useful. Also added documentation for the various runtime contexts & modes. |
cevich
force-pushed
the
replace_skips
branch
3 times, most recently
from
f8cfae9
to
94d78ff
Compare
|
Force-push: Updated docs. |
cevich
changed the title
cevich
changed the title
cevich
changed the title
cevich
force-pushed
the
replace_skips
branch
2 times, most recently
from
3d0d412
to
d82556d
Compare
cevich
changed the title
cevich
force-pushed
the
replace_skips
branch
2 times, most recently
from
81cd653
to
9705414
Compare
Using both the 'skip' and 'only_if' features at the same time may be hard for maintainers to decipher. Consolidate them into `only_if` since that bypasses creation of the task all together - meaning there are potentially fewer tasks for a developer to scroll through. Since the `multiarch` Cirrus-Cron build no-longer depends on the direct "build-ability" from the current repo. state, it can be further optimized. When operating in this context, avoid running many/most other tasks, depending instead only on `ext_svc_check`. Finally, add a simple document describing the various runtime contexts along with the list of expected tasks. Reference this prominently right in front of every `only_if` so it's impossible for a maintainer to miss. Signed-off-by: Chris Evich <cevich@redhat.com>
|
Latest contexts and runtime tests:
|
cevich
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #14437
Using both the 'skip' and 'only_if' features at the same time may be
hard for maintainers to decipher. Consolidate them into
only_ifsincethat bypasses creation of the task all together - meaning there are
fewer tasks for a developer to scroll through.
Since the
multiarchCirrus-Cron build no-longer depends on the direct"build-ability" from the current repo. state, it can be further
optimized. When operating in this context, avoid running many/most
other tasks, depending instead only on
ext_svc_check.Does this PR introduce a user-facing change?