Podman pull --all-tags shorthand option #14932
Conversation
|
LGTM |
test/e2e/pull_test.go
Outdated
| It("podman pull check all tags shorthand", func() { | ||
| session := podmanTest.Podman([]string{"pull", "-a", "quay.io/libpod/testdigest_v2s2"}) | ||
| session.WaitWithDefaultTimeout() | ||
| Expect(session).Should(Exit(0)) | ||
|
|
||
| session = podmanTest.Podman([]string{"images"}) | ||
| session.WaitWithDefaultTimeout() | ||
| Expect(session).Should(Exit(0)) | ||
| Expect(len(session.OutputToStringArray())).To(BeNumerically(">=", 2), "Expected at least two images") | ||
| }) |
There was a problem hiding this comment.
Actually pulling images is slow and result in flakes. Do we actually have to test this twice with the short and log flag name? I think at least it would make sense to move this into the other --all-tags test so it can skip the downloaded layers instead of having to download everything again.
There was a problem hiding this comment.
Yes if we have more then one --all-tags test, just change one to -a and you don't have ot add more tests.
There was a problem hiding this comment.
We only have one --all-tags test, what I want is to move the command with the new flag into the same test so it uses the same storage and does not need to repull all layers.
There was a problem hiding this comment.
Is the latest change what you wanted?
|
Code LGTM, but I'd like the test comment from @Luap99 addressed before we merge. |
I added the shorthand option for `podman pull --all-tags`. Like Docker, Podman can now do `podman pull -a`. Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
jakecorrenti
force-pushed
the
pull-all-tags-shorthand
branch
from
c9693d3
to
90607a6
Compare
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
Test failures look like a registry issue |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
The buildah-bud tests are failing which I'm not parsing as the changes are in pull? Otherwise LGTM |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
I added the shorthand option for
podman pull --all-tags. Like Docker,Podman can now do
podman pull -a.Addresses a task from #14917
Signed-off-by: Jake Correnti jcorrenti13@gmail.com
Does this PR introduce a user-facing change?