Closes #15617: emit container labels for container exited and exec died events

[thediveo]

Does this PR introduce a user-facing change?

The container-related events (with ``Type`=`container`) for `Status` of `died` and `exec_died`
now carry the container's labels in the `Attributes` event field, as for instance the `start` container event
already does.

[thediveo]

• I don't see any event_test.go, so creating a new one is currently out of reach for me for a first podman PR.
• in the same way test/system/090-events.bats is out of reach for me, more so as this is a fully unknown testing tool to me.

[edsantiago]

Here ya go

# Prior to #15633, container labels would not appear in 'die' log events
@test "events - labels included in container die" {
    local cname=c$(random_string 15)
    local lname=l$(random_string 10)
    local lvalue="v$(random_string 10) $(random_string 5)"

    run_podman 17 --events-backend=file run --rm \
               --name=$cname \
               --label=$lname="$lvalue" \
               $IMAGE sh -c 'exit 17'
    run_podman --events-backend=file events \
               --filter=container=$cname \
               --filter=status=died \
               --stream=false \
               --format=json
    local label_found=$(jq -r ".Attributes.$lname" <<<"$output")
    assert "$label_found" = "$lvalue" "podman-events output includes container label"
}

[vrothberg]

Thanks, @edsantiago !

[rhatdan]

LGTM other then handling tests.

[edsantiago]

UPDATE: now that #15644 has merged, please rebase and change the last few lines of my suggestion above to:

    ...
               --stream=false \
               --format="{{.Attributes.$lname}}"
    assert "$output" = "$lvalue" "podman-events output includes container label"

[edsantiago]

LGTM. Thanks again.

[thediveo]

@edsantiago @vrothberg many thanks for helping me over the bats-based unit test hurdles; things start to finally dawn for me now.

And now for something not completely different, the obligatory xkcd https://xkcd.com/1296/ ;)

[edsantiago]

Oops! My bad, I didn't test with podman-remote, which apparently rejects --events-backend. You will need to add skip_if_remote as the first line of the new test. Sorry about that.

[vrothberg]

/lgtm

Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thediveo, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment