Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kube play liveness probe http path #15968

Merged
merged 1 commit into from Sep 28, 2022
Merged

fix: kube play liveness probe http path #15968

merged 1 commit into from Sep 28, 2022

Conversation

piotr-sk
Copy link
Contributor

Follow-up on the 15958.

  • When a pod with HTTP liveness probe is created using podman kube play, ensure the Kubernetes defaults value for path is set correctly.
  • Update the URI scheme to use lowercase and use this value in code (not used otherwise, URI are lowercase)

Fixes #15855 for the final parameter. I am sorry that I missed this in the original pull request.

Does this PR introduce a user-facing change?

None

@piotr-sk
fix: kube play liveness probe http path
66517d8 
Use the default / for http probe path.
Update to URI schemes ensuring lowercase

Signed-off-by: Piotr <piotr.skoczylas@gmail.com>
@piotr-sk piotr-sk force-pushed the fix/kube_play_liveness_probe_path branch from 8698482 to 66517d8 Compare September 28, 2022 07:57
@mheon
Copy link
Member

mheon commented Sep 28, 2022

/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, piotr-sk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 40b28dc into containers:main Sep 28, 2022
@piotr-sk piotr-sk deleted the fix/kube_play_liveness_probe_path branch September 29, 2022 05:22
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

play kube liveness HTTP probe does not use defaults
4 participants
@piotr-sk @mheon @rhatdan @openshift-merge-robot