Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] GHA: Fix cirrus re-run workflow for other repos. #16573

Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Nov 21, 2022

The checkout action by default, clones the current repository. However, since this workflow is re-used by other repos, and it calls scripts in the podman repo, those calls will all fail. Fix this by hard-coding the podman repo.

Ref: https://github.com/actions/checkout

Signed-off-by: Chris Evich cevich@redhat.com

Does this PR introduce a user-facing change?

None

The checkout action by default, clones the current repository.  However,
since this workflow is re-used by other repos, and it calls scripts in
the podman repo, those calls will all fail.  Fix this by hard-coding the
podman repo.

Ref: https://github.com/actions/checkout

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 21, 2022
@cevich
Copy link
Member Author

cevich commented Nov 21, 2022

Example of the error this will fix:

https://github.com/containers/buildah/actions/runs/3515841465/jobs/5891615031

@cevich
Copy link
Member Author

cevich commented Nov 22, 2022

@containers/podman-maintainers PTAL - this fixes a problem affecting our cirrus-cron monitoring jobs.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@lsm5
Copy link
Member

lsm5 commented Nov 24, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit fd142ef into containers:main Nov 24, 2022
@cevich cevich deleted the fix_rerun_gha_workflow branch April 18, 2023 14:44
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants