Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update c/storage after https://github.com/containers/storage/pull/1436 #16581

Merged
merged 1 commit into from Dec 5, 2022
Merged

Update c/storage after https://github.com/containers/storage/pull/1436 #16581

merged 1 commit into from Dec 5, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 21, 2022

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

@mtrmac: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2022
@mtrmac mtrmac mentioned this pull request Nov 21, 2022
Merged
@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 21, 2022

Now includes updates to avoid newly deprecated interfaces.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 22, 2022

Current test failures match #16578 , so I guess this is blocked on that work.

@rhatdan
Copy link
Member

rhatdan commented Nov 22, 2022

#16578 should fix this PR, you will need to rebase.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@mtrmac
Copy link
Collaborator Author

mtrmac commented Dec 1, 2022

The c/storage PR was merged, and requires Podman updates from this PR to avoid now-deprecated interfaces.

So, leaving this PR open, and ready for merge at some point. Merging it before the eventual vendor dance, and running the new code base in the meantime, might also improve our confidence in the c/storage changes a bit.

@mtrmac mtrmac changed the title DO NOT MERGE: Testing https://github.com/containers/storage/pull/1436 Update c/storage after https://github.com/containers/storage/pull/1436 Dec 1, 2022
@mtrmac mtrmac marked this pull request as ready for review December 1, 2022 14:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@mtrmac
Update c/storage after containers/storage#1436
c83efd0 
... and update to remove the now-deprecated Locker interface.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This was referenced Dec 1, 2022
Closed
Merged
@rhatdan
Copy link
Member

rhatdan commented Dec 5, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan removed the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Dec 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit c942f77 into containers:main Dec 5, 2022
@mtrmac mtrmac deleted the modified-test branch December 5, 2022 18:26
@edsantiago edsantiago mentioned this pull request Dec 5, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtrmac @rhatdan @openshift-merge-robot