runtime: do not chown idmapped volumes

[giuseppe]

do not chown a volume when idmap is used.

Closes: #16724

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Does this PR introduce a user-facing change?

Now volumes that use idmap are not chowned to the UID/GID of the root in the container

[M1cha]

I didn't test this yet but what happens if you create the volume externally and it still has NeedsChown set to true because it was never used before?

Or even worse, what if you create it externally, have a container without the idmap flag chown it, and then use the same volume in a container with the idmap flag? It should probably show a warning since neither doing nothing nor chowning back to 0 sound like decisions that should be made implicitly.

[rhatdan]

LGTM

[mheon]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment