Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-mac-helper: exit 1 on error #17786

Merged
merged 1 commit into from
Mar 14, 2023
Merged

podman-mac-helper: exit 1 on error #17786

merged 1 commit into from
Mar 14, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 14, 2023

We should return a proper exit code to signal the failure.

Fixes #17785

Does this PR introduce a user-facing change?

podman-mac-helper now exits with 1 on error.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@Luap99
Copy link
Member Author

Luap99 commented Mar 14, 2023

@n1hility @baude @ashley-cui PTAL

ashley-cui
ashley-cui reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 mentioned this pull request Mar 14, 2023
Closed
@Luap99
podman-mac-helper: exit 1 on error
bae07b6 
We should return a proper exit code to signal the failure.

[NO NEW TESTS NEEDED] We do have any tests on macOS.

Fixes containers#17785

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@n1hility
Copy link
Member

thanks for catching this
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@rhatdan
Copy link
Member

rhatdan commented Mar 14, 2023

/hold
Until tests pass

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@TomSweeneyRedHat
Copy link
Member

LGTM
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 68bf497 into containers:main Mar 14, 2023
@Luap99 Luap99 deleted the mac-helper-error branch March 15, 2023 12:38
@Luap99 Luap99 mentioned this pull request Mar 16, 2023
Merged
@Luap99 Luap99 mentioned this pull request Mar 24, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

Assignees

@n1hility n1hility

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using podman-mac-helper install, does not exit 1 on error
6 participants
@Luap99 @n1hility @rhatdan @TomSweeneyRedHat @ashley-cui @openshift-merge-robot