Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Document building Podman remote on Windows hosts #17845

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Mar 18, 2023

Fixes #17481

Adds documentation for building Podman remote on Windows hosts and also references it in CONTRIBUTING.md

Does this PR introduce a user-facing change?

Extend contributing guide with `build_windows.md` containing instructions how to build Podman remote client from sources on Windows hosts.

@baude baude added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Mar 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Mar 19, 2023
@baude
Copy link
Member

baude commented Mar 19, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2023
@baude
Copy link
Member

baude commented Mar 19, 2023

i think this is release note worthy ?

@arixmkii
Copy link
Contributor Author

Updated release note.

@rhatdan
Copy link
Member

rhatdan commented Mar 21, 2023

@n1hility PTAL

CONTRIBUTING.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
build_windows.md Outdated Show resolved Hide resolved
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nit, but overall looks good. Thanks @arixmkii for providing this PR. I too want a head nod from @n1hility to make sure nothing is missing in the documented procedure.

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2023

@arixmkii Can you update this addressing @TomSweeneyRedHat comments.
Thanks for the PR.

@arixmkii
Copy link
Contributor Author

Will apply fixes tomorrow. Thank you for detailed review.

Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
@arixmkii
Copy link
Contributor Author

Applied all suggestions. Added one of the suggestions to the build_osx.md, which was the origin for that text.

@rhatdan
Copy link
Member

rhatdan commented Mar 29, 2023

/lgtm
Thanks @arixmkii

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit fb80f6f into containers:main Mar 29, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
@arixmkii arixmkii deleted the win-build-doc branch March 1, 2024 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman Windows build (including cross build) instructions
5 participants